Skip to content

Commit 532f69e

Browse files
wooormwooorm
committed
Remove loose fields
* Related to remarkjs/remark#364
1 parent 7441ea6 commit 532f69e

File tree

22 files changed

+5
-122
lines changed

22 files changed

+5
-122
lines changed

‎lib/contents.js

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ function insert(entry, parent, tight, prefix) {
4949
var children = parent.children
5050
var length = children.length
5151
var last = children[length - 1]
52-
var isLoose = false
5352
var index
5453
var item
5554

@@ -104,31 +103,6 @@ function insert(entry, parent, tight, prefix) {
104103
}
105104
}
106105
}
107-
108-
// To do: remove `loose` in next major release.
109-
if (parent.type === LIST_ITEM) {
110-
parent.loose = tight ? false : children.length > 1
111-
} else {
112-
if (tight) {
113-
isLoose = false
114-
} else {
115-
index = -1
116-
117-
while (++index < length) {
118-
if (children[index].loose) {
119-
isLoose = true
120-
121-
break
122-
}
123-
}
124-
}
125-
126-
index = -1
127-
128-
while (++index < length) {
129-
children[index].loose = isLoose
130-
}
131-
}
132106
}
133107

134108
function all(children) {
@@ -171,6 +145,5 @@ function list() {
171145

172146
// Create a list item.
173147
function listItem() {
174-
// To do: remove `loose` in next major.
175-
return {type: LIST_ITEM, loose: false, spread: false, children: []}
148+
return {type: LIST_ITEM, spread: false, children: []}
176149
}

‎readme.md

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,7 @@ Yields:
5050
type: 'list',
5151
ordered: false,
5252
spread: true,
53-
children: [
54-
{
55-
type: 'listItem',
56-
loose: true,
57-
spread: true,
58-
children: [Array]
59-
}
60-
]
53+
children: [ { type: 'listItem', spread: true, children: [Array] } ]
6154
}
6255
}
6356
```

‎test/fixtures/custom-heading/output.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"children": [
99
{
1010
"type": "listItem",
11-
"loose": true,
1211
"spread": true,
1312
"children": [
1413
{
@@ -34,7 +33,6 @@
3433
"children": [
3534
{
3635
"type": "listItem",
37-
"loose": false,
3836
"spread": false,
3937
"children": [
4038
{
@@ -57,7 +55,6 @@
5755
},
5856
{
5957
"type": "listItem",
60-
"loose": false,
6158
"spread": false,
6259
"children": [
6360
{
@@ -84,7 +81,6 @@
8481
},
8582
{
8683
"type": "listItem",
87-
"loose": false,
8884
"spread": false,
8985
"children": [
9086
{

‎test/fixtures/deep-headings-with-config/output.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"children": [
99
{
1010
"type": "listItem",
11-
"loose": true,
1211
"spread": true,
1312
"children": [
1413
{
@@ -34,7 +33,6 @@
3433
"children": [
3534
{
3635
"type": "listItem",
37-
"loose": false,
3836
"spread": false,
3937
"children": [
4038
{
@@ -57,7 +55,6 @@
5755
},
5856
{
5957
"type": "listItem",
60-
"loose": false,
6158
"spread": false,
6259
"children": [
6360
{
@@ -84,7 +81,6 @@
8481
},
8582
{
8683
"type": "listItem",
87-
"loose": false,
8884
"spread": false,
8985
"children": [
9086
{

‎test/fixtures/deep-headings/output.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"children": [
99
{
1010
"type": "listItem",
11-
"loose": true,
1211
"spread": true,
1312
"children": [
1413
{
@@ -34,7 +33,6 @@
3433
"children": [
3534
{
3635
"type": "listItem",
37-
"loose": false,
3836
"spread": false,
3937
"children": [
4038
{
@@ -61,7 +59,6 @@
6159
},
6260
{
6361
"type": "listItem",
64-
"loose": false,
6562
"spread": false,
6663
"children": [
6764
{

‎test/fixtures/image-in-link-in-heading/output.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"children": [
99
{
1010
"type": "listItem",
11-
"loose": true,
1211
"spread": true,
1312
"children": [
1413
{
@@ -34,7 +33,6 @@
3433
"children": [
3534
{
3635
"type": "listItem",
37-
"loose": false,
3836
"spread": false,
3937
"children": [
4038
{
@@ -57,7 +55,6 @@
5755
},
5856
{
5957
"type": "listItem",
60-
"loose": false,
6158
"spread": false,
6259
"children": [
6360
{
@@ -84,7 +81,6 @@
8481
},
8582
{
8683
"type": "listItem",
87-
"loose": false,
8884
"spread": false,
8985
"children": [
9086
{

‎test/fixtures/maximum-depth-1/output.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"children": [
99
{
1010
"type": "listItem",
11-
"loose": false,
1211
"spread": false,
1312
"children": [
1413
{

‎test/fixtures/maximum-depth-3/output.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"children": [
99
{
1010
"type": "listItem",
11-
"loose": true,
1211
"spread": true,
1312
"children": [
1413
{
@@ -34,7 +33,6 @@
3433
"children": [
3534
{
3635
"type": "listItem",
37-
"loose": true,
3836
"spread": true,
3937
"children": [
4038
{
@@ -60,7 +58,6 @@
6058
"children": [
6159
{
6260
"type": "listItem",
63-
"loose": false,
6461
"spread": false,
6562
"children": [
6663
{

‎test/fixtures/maximum-depth-6/output.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"children": [
99
{
1010
"type": "listItem",
11-
"loose": true,
1211
"spread": true,
1312
"children": [
1413
{
@@ -34,7 +33,6 @@
3433
"children": [
3534
{
3635
"type": "listItem",
37-
"loose": true,
3836
"spread": true,
3937
"children": [
4038
{
@@ -60,7 +58,6 @@
6058
"children": [
6159
{
6260
"type": "listItem",
63-
"loose": true,
6461
"spread": true,
6562
"children": [
6663
{
@@ -86,7 +83,6 @@
8683
"children": [
8784
{
8885
"type": "listItem",
89-
"loose": true,
9086
"spread": true,
9187
"children": [
9288
{
@@ -112,7 +108,6 @@
112108
"children": [
113109
{
114110
"type": "listItem",
115-
"loose": true,
116111
"spread": true,
117112
"children": [
118113
{
@@ -138,7 +133,6 @@
138133
"children": [
139134
{
140135
"type": "listItem",
141-
"loose": false,
142136
"spread": false,
143137
"children": [
144138
{

‎test/fixtures/normal-attr/output.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"children": [
99
{
1010
"type": "listItem",
11-
"loose": true,
1211
"spread": true,
1312
"children": [
1413
{
@@ -34,7 +33,6 @@
3433
"children": [
3534
{
3635
"type": "listItem",
37-
"loose": false,
3836
"spread": false,
3937
"children": [
4038
{
@@ -57,7 +55,6 @@
5755
},
5856
{
5957
"type": "listItem",
60-
"loose": false,
6158
"spread": false,
6259
"children": [
6360
{
@@ -84,7 +81,6 @@
8481
},
8582
{
8683
"type": "listItem",
87-
"loose": false,
8884
"spread": false,
8985
"children": [
9086
{

‎test/fixtures/normal-literal-dashes/output.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"children": [
99
{
1010
"type": "listItem",
11-
"loose": true,
1211
"spread": true,
1312
"children": [
1413
{
@@ -34,7 +33,6 @@
3433
"children": [
3534
{
3635
"type": "listItem",
37-
"loose": false,
3836
"spread": false,
3937
"children": [
4038
{
@@ -61,7 +59,6 @@
6159
},
6260
{
6361
"type": "listItem",
64-
"loose": false,
6562
"spread": false,
6663
"children": [
6764
{

‎test/fixtures/normal-nesting-inverted/output.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"children": [
99
{
1010
"type": "listItem",
11-
"loose": true,
1211
"spread": true,
1312
"children": [
1413
{
@@ -18,7 +17,6 @@
1817
"children": [
1918
{
2019
"type": "listItem",
21-
"loose": false,
2220
"spread": false,
2321
"children": [
2422
{
@@ -45,7 +43,6 @@
4543
},
4644
{
4745
"type": "listItem",
48-
"loose": true,
4946
"spread": true,
5047
"children": [
5148
{
@@ -71,7 +68,6 @@
7168
"children": [
7269
{
7370
"type": "listItem",
74-
"loose": false,
7571
"spread": false,
7672
"children": [
7773
{
@@ -98,7 +94,6 @@
9894
},
9995
{
10096
"type": "listItem",
101-
"loose": false,
10297
"spread": false,
10398
"children": [
10499
{

‎test/fixtures/normal-singular/output.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"children": [
99
{
1010
"type": "listItem",
11-
"loose": true,
1211
"spread": true,
1312
"children": [
1413
{
@@ -34,7 +33,6 @@
3433
"children": [
3534
{
3635
"type": "listItem",
37-
"loose": false,
3836
"spread": false,
3937
"children": [
4038
{
@@ -57,7 +55,6 @@
5755
},
5856
{
5957
"type": "listItem",
60-
"loose": false,
6158
"spread": false,
6259
"children": [
6360
{
@@ -84,7 +81,6 @@
8481
},
8582
{
8683
"type": "listItem",
87-
"loose": false,
8884
"spread": false,
8985
"children": [
9086
{

0 commit comments

Comments
 (0)