Refactor to improve bundle size

Author: wooorm

index.js

@@ -2,17 +2,12 @@
 
 var visit = require('unist-util-visit')
 
-module.exports = getDefinitionFactory
+module.exports = createGetDefinition
 
 var own = {}.hasOwnProperty
 
 // Get a definition in `node` by `identifier`.
-function getDefinitionFactory(node, options) {
-  return getterFactory(gather(node, options))
-}
-
-// Gather all definitions in `node`
-function gather(node) {
+function createGetDefinition(node) {
   var cache = {}
 
   if (!node || !node.type) {
@@ -21,27 +16,22 @@ function gather(node) {
 
   visit(node, 'definition', ondefinition)
 
-  return cache
+  return getDefinition
 
   function ondefinition(definition) {
-    var id = normalise(definition.identifier)
-    if (!own.call(cache, id)) {
+    var id = clean(definition.identifier)
+    if (id && !own.call(cache, id)) {
       cache[id] = definition
     }
   }
-}
-
-// Factory to get a node from the given definition-cache.
-function getterFactory(cache) {
-  return getter
 
   // Get a node from the bound definition-cache.
-  function getter(identifier) {
-    var id = identifier && normalise(identifier)
+  function getDefinition(identifier) {
+    var id = clean(identifier)
     return id && own.call(cache, id) ? cache[id] : null
   }
 }
 
-function normalise(identifier) {
-  return identifier.toUpperCase()
+function clean(value) {
+  return String(value || '').toUpperCase()
 }

test.js

@@ -5,7 +5,6 @@ var remark = require('remark')
 var definitions = require('.')
 
 test('mdast-util-definitions', function (t) {
-  var getDefinition
   var tree
 
   t.throws(
@@ -17,10 +16,9 @@ test('mdast-util-definitions', function (t) {
   )
 
   tree = remark().parse('[example]: https://example.com "Example"')
-  getDefinition = definitions(tree)
 
   t.deepLooseEqual(
-    getDefinition('example'),
+    definitions(tree)('example'),
     {
       type: 'definition',
       identifier: 'example',
@@ -35,13 +33,12 @@ test('mdast-util-definitions', function (t) {
     'should return a definition'
   )
 
-  t.equal(getDefinition('foo'), null, 'should return null when not found')
+  t.equal(definitions(tree)('foo'), null, 'should return null when not found')
 
   tree = remark().parse('[__proto__]: https://proto.com "Proto"')
-  getDefinition = definitions(tree)
 
   t.deepLooseEqual(
-    getDefinition('__proto__'),
+    definitions(tree)('__proto__'),
     {
       type: 'definition',
       identifier: '__proto__',
@@ -60,7 +57,7 @@ test('mdast-util-definitions', function (t) {
   t.equal({}.type, undefined, 'should not polute the prototype')
 
   t.deepEqual(
-    getDefinition('toString'),
+    definitions(tree)('toString'),
     null,
     'should work on weird identifiers when not found'
   )
@@ -75,5 +72,11 @@ test('mdast-util-definitions', function (t) {
     'should prefer the first of duplicate definitions'
   )
 
+  t.deepEqual(
+    definitions(tree)(''),
+    null,
+    'should not return something for a missing identifier'
+  )
+
   t.end()
 })