Add support for minifying doctypes

wooorm · wooorm · commit baac1a8d8791 · 2018-06-24T14:02:54.000+02:00
Apparently, `&lt;!doctypehtml&gt;`, `&lt;!doctypehtml public"something"&gt;`,
`&lt;!doctypehtml system"something"&gt;`, and
`&lt;!doctypehtml public"something""else"&gt;` are all valid, except for
the parse errors that is, and don’t cause quirksmode!
diff --git a/lib/doctype.js b/lib/doctype.js
@@ -4,27 +4,27 @@ module.exports = doctype
 
 /* Stringify a doctype `node`. */
 function doctype(ctx, node) {
+  var sep = ctx.tightDoctype ? '' : ' '
+  var name = node.name
   var pub = node.public
   var sys = node.system
-  var val = '<!doctype'
+  var val = ['<!doctype']
 
-  if (!node.name) {
-    return val + '>'
-  }
-
-  val += ' ' + node.name
+  if (name) {
+    val.push(sep, name)
 
-  if (pub != null) {
-    val += ' public ' + smart(pub)
-  } else if (sys != null) {
-    val += ' system'
-  }
+    if (pub != null) {
+      val.push(' public', sep, smart(pub))
+    } else if (sys != null) {
+      val.push(' system')
+    }
 
-  if (sys != null) {
-    val += ' ' + smart(sys)
+    if (sys != null) {
+      val.push(sep, smart(sys))
+    }
   }
 
-  return val + '>'
+  return val.join('') + '>'
 }
 
 function smart(value) {
diff --git a/lib/index.js b/lib/index.js
@@ -76,6 +76,7 @@ function toHTML(node, options) {
     alternative: smart ? alternative : null,
     unquoted: Boolean(settings.preferUnquoted),
     tight: settings.tightAttributes,
+    tightDoctype: Boolean(settings.tightDoctype),
     tightLists: settings.tightCommaSeparatedLists,
     tightClose: settings.tightSelfClosing,
     collapseEmpty: settings.collapseEmptyAttributes,
diff --git a/readme.md b/readme.md
@@ -91,8 +91,8 @@ if `closeSelfClosing: true`.
 ###### `options.tightCommaSeparatedLists`
 
 Join known comma-separated attribute values with just a comma (`,`),
-instead of padding them on the right as well (`,`) (`boolean`,
-default: `false`).
+instead of padding them on the right as well (`,·`, where `·` represents a
+space) (`boolean`, default: `false`).
 
 ###### `options.tightAttributes`
 
@@ -101,6 +101,12 @@ Join attributes together, without white-space, if possible:
 instead to save bytes (`boolean`, default: `false`).  **Note**: creates
 invalid (but working) markup.
 
+###### `options.tightDoctype`
+
+Drop unneeded spaces in doctypes: `<!doctypehtml>` instead of `<!doctype html>`
+to save bytes (`boolean`, default: `false`).  **Note**: creates
+invalid (but working) markup.
+
 ###### `options.allowParseErrors`
 
 Do not encode characters which trigger parse errors (even though they
diff --git a/test/doctype.js b/test/doctype.js
@@ -17,6 +17,12 @@ test('`text`', function(t) {
     'should stringify doctypes with `name`'
   )
 
+  t.deepEqual(
+    to(u('doctype', {name: 'html'}), {tightDoctype: true}),
+    '<!doctypehtml>',
+    'should stringify doctypes with `name` tightly in `tightDoctype` mode'
+  )
+
   t.deepEqual(
     to(
       u('doctype', {
@@ -32,13 +38,28 @@ test('`text`', function(t) {
     to(
       u('doctype', {
         name: 'html',
-        system: 'about:legacy-compat'
-      })
+        public: '-//W3C//DTD XHTML 1.0 Transitional//EN'
+      }),
+      {tightDoctype: true}
     ),
+    '<!doctypehtml public"-//W3C//DTD XHTML 1.0 Transitional//EN">',
+    'should stringify doctypes with a public identifier tightly in `tightDoctype` mode'
+  )
+
+  t.deepEqual(
+    to(u('doctype', {name: 'html', system: 'about:legacy-compat'})),
     '<!doctype html system "about:legacy-compat">',
     'should stringify doctypes with a system identifier'
   )
 
+  t.deepEqual(
+    to(u('doctype', {name: 'html', system: 'about:legacy-compat'}), {
+      tightDoctype: true
+    }),
+    '<!doctypehtml system"about:legacy-compat">',
+    'should stringify doctypes with a system identifier tightly in `tightDoctype` mode'
+  )
+
   t.deepEqual(
     to(
       u('doctype', {
@@ -51,6 +72,19 @@ test('`text`', function(t) {
     'should stringify doctypes with both identifiers'
   )
 
+  t.deepEqual(
+    to(
+      u('doctype', {
+        name: 'html',
+        public: '-//W3C//DTD HTML 4.01//',
+        system: 'http://www.w3.org/TR/html4/strict.dtd'
+      }),
+      {tightDoctype: true}
+    ),
+    '<!doctypehtml public"-//W3C//DTD HTML 4.01//""http://www.w3.org/TR/html4/strict.dtd">',
+    'should stringify doctypes with both identifiers tightly in `tightDoctype` mode'
+  )
+
   t.deepEqual(
     to(
       u('doctype', {
