Refactor to improve bundle size

Author: wooorm

convert.js

@@ -3,16 +3,16 @@
 module.exports = convert
 
 function convert(test) {
-  if (typeof test === 'string') {
-    return tagNameFactory(test)
+  if (test == null) {
+    return element
   }
 
-  if (test === null || test === undefined) {
-    return element
+  if (typeof test === 'string') {
+    return tagNameFactory(test)
   }
 
   if (typeof test === 'object') {
-    return any(test)
+    return anyFactory(test)
   }
 
   if (typeof test === 'function') {
@@ -22,28 +22,20 @@ function convert(test) {
   throw new Error('Expected function, string, or array as test')
 }
 
-function convertAll(tests) {
-  var length = tests.length
+function anyFactory(tests) {
   var index = -1
-  var results = []
+  var checks = []
 
-  while (++index < length) {
-    results[index] = convert(tests[index])
+  while (++index < tests.length) {
+    checks[index] = convert(tests[index])
   }
 
-  return results
-}
-
-function any(tests) {
-  var checks = convertAll(tests)
-  var length = checks.length
-
-  return matches
+  return any
 
-  function matches() {
+  function any() {
     var index = -1
 
-    while (++index < length) {
+    while (++index < checks.length) {
       if (checks[index].apply(this, arguments)) {
         return true
       }

index.js

@@ -8,26 +8,24 @@ isElement.convert = convert
 
 // Check if if `node` is an `element` and whether it passes the given test.
 function isElement(node, test, index, parent, context) {
-  var hasParent = parent !== null && parent !== undefined
-  var hasIndex = index !== null && index !== undefined
   var check = convert(test)
 
   if (
-    hasIndex &&
+    index != null &&
     (typeof index !== 'number' || index < 0 || index === Infinity)
   ) {
     throw new Error('Expected positive finite index for child node')
   }
 
-  if (hasParent && (!parent.type || !parent.children)) {
+  if (parent != null && (!parent.type || !parent.children)) {
     throw new Error('Expected parent node')
   }
 
   if (!node || !node.type || typeof node.type !== 'string') {
     return false
   }
 
-  if (hasParent !== hasIndex) {
+  if ((parent == null) !== (index == null)) {
     throw new Error('Expected both parent and index')
   }
 

package.json

@@ -58,14 +58,22 @@
   "xo": {
     "prettier": true,
     "esnext": false,
+    "ignores": [
+      "hast-util-is-element.js"
+    ],
     "rules": {
+      "eqeqeq": [
+        "error",
+        "always",
+        {
+          "null": "ignore"
+        }
+      ],
       "max-params": "off",
-      "unicorn/prefer-includes": "off",
+      "no-eq-null": "off",
+      "unicorn/prefer-type-error": "off",
       "unicorn/prefer-reflect-apply": "off"
-    },
-    "ignores": [
-      "hast-util-is-element.js"
-    ]
+    }
   },
   "nyc": {
     "check-coverage": true,