[Notifier] Use abstract test cases in 5.x

Author: OskarStark

Tests/ZulipTransportFactoryTest.php

@@ -11,75 +11,47 @@
 
 namespace Symfony\Component\Notifier\Bridge\Zulip\Tests;
 
-use PHPUnit\Framework\TestCase;
 use Symfony\Component\Notifier\Bridge\Zulip\ZulipTransportFactory;
-use Symfony\Component\Notifier\Exception\IncompleteDsnException;
-use Symfony\Component\Notifier\Exception\MissingRequiredOptionException;
-use Symfony\Component\Notifier\Exception\UnsupportedSchemeException;
-use Symfony\Component\Notifier\Transport\Dsn;
+use Symfony\Component\Notifier\Tests\TransportFactoryTestCase;
+use Symfony\Component\Notifier\Transport\TransportFactoryInterface;
 
-final class ZulipTransportFactoryTest extends TestCase
+final class ZulipTransportFactoryTest extends TransportFactoryTestCase
 {
-    public function testCreateWithDsn()
+    /**
+     * @return ZulipTransportFactory
+     */
+    public function createFactory(): TransportFactoryInterface
     {
-        $factory = $this->createFactory();
-
-        $transport = $factory->create(Dsn::fromString('zulip://email:token@host.test?channel=testChannel'));
-
-        $this->assertSame('zulip://host.test?channel=testChannel', (string) $transport);
-    }
-
-    public function testCreateWithMissingOptionChannelThrowsMissingRequiredOptionException()
-    {
-        $factory = $this->createFactory();
-
-        $this->expectException(MissingRequiredOptionException::class);
-
-        $factory->create(Dsn::fromString('zulip://email:token@host'));
-    }
-
-    public function testCreateWithOnlyEmailOrTokenThrowsIncompleteDsnException()
-    {
-        $factory = $this->createFactory();
-
-        $this->expectException(IncompleteDsnException::class);
-        $factory->create(Dsn::fromString('zulip://testOneOfEmailOrToken@host.test?channel=testChannel'));
+        return new ZulipTransportFactory();
     }
 
-    public function testSupportsReturnsTrueWithSupportedScheme()
+    public function createProvider(): iterable
     {
-        $factory = $this->createFactory();
-
-        $this->assertTrue($factory->supports(Dsn::fromString('zulip://host?channel=testChannel')));
+        yield [
+            'zulip://host.test?channel=testChannel',
+            'zulip://email:token@host.test?channel=testChannel',
+        ];
     }
 
-    public function testSupportsReturnsFalseWithUnsupportedScheme()
+    public function supportsProvider(): iterable
     {
-        $factory = $this->createFactory();
-
-        $this->assertFalse($factory->supports(Dsn::fromString('somethingElse://host?channel=testChannel')));
+        yield [true, 'zulip://host?channel=testChannel'];
+        yield [false, 'somethingElse://host?channel=testChannel'];
     }
 
-    public function testUnsupportedSchemeThrowsUnsupportedSchemeException()
+    public function incompleteDsnProvider(): iterable
     {
-        $factory = $this->createFactory();
-
-        $this->expectException(UnsupportedSchemeException::class);
-        $factory->create(Dsn::fromString('somethingElse://email:token@host?channel=testChannel'));
+        yield 'missing email or token' => ['zulip://testOneOfEmailOrToken@host.test?channel=testChannel'];
     }
 
-    public function testUnsupportedSchemeThrowsUnsupportedSchemeExceptionEvenIfRequiredOptionIsMissing()
+    public function missingRequiredOptionProvider(): iterable
     {
-        $factory = $this->createFactory();
-
-        $this->expectException(UnsupportedSchemeException::class);
-
-        // unsupported scheme and missing "channel" option
-        $factory->create(Dsn::fromString('somethingElse://email:token@host'));
+        yield 'missing option: channel' => ['zulip://email:token@host'];
     }
 
-    private function createFactory(): ZulipTransportFactory
+    public function unsupportedSchemeProvider(): iterable
     {
-        return new ZulipTransportFactory();
+        yield ['somethingElse://email:token@host?channel=testChannel'];
+        yield ['somethingElse://email:token@host']; // missing "channel" option
     }
 }