Skip to content

Commit 2d0cb94

Browse files
committed
reversing pathinfo logic
This creates extra comments in the final .js files, to help debugging. This was a mistake when originally added - the logic was reversed.
1 parent 2cae5df commit 2d0cb94

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

lib/config-generator.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ class ConfigGenerator {
107107
// will use the CDN path (if one is available) so that split
108108
// chunks load internally through the CDN.
109109
publicPath: this.webpackConfig.getRealPublicPath(),
110-
pathinfo: this.webpackConfig.isProduction()
110+
pathinfo: !this.webpackConfig.isProduction()
111111
};
112112
}
113113

test/functional.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -505,6 +505,11 @@ describe('Functional tests using webpack', function() {
505505
'main.js',
506506
'// comments in no_require.js'
507507
);
508+
// check for any webpack-added comments
509+
webpackAssert.assertOutputFileDoesNotContain(
510+
'main.js',
511+
'/*!'
512+
);
508513
// extra spaces should not live in the CSS file
509514
webpackAssert.assertOutputFileDoesNotContain(
510515
'styles.css',

0 commit comments

Comments
 (0)