Skip to content

Commit c15d918

Browse files
committed
minor #2759 [CI] Configure Git username/email to github-actions[bot] when comitting version updates (Kocal)
This PR was merged into the 2.x branch. Discussion ---------- [CI] Configure Git username/email to github-actions[bot] when comitting version updates | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> As suggested by `@tucksaun` privately, this change, inspired from the Symfony CLI https://github.com/symfony-cli/symfony-cli/blob/main/.github/workflows/go_generate_update.yml#L9-L12, will fix the display of the git committer when NPM versions are updated, e.g.: 00fa069 Commits ------- 40e80c5 [CI] Configure Git username/email to github-actions[bot] when comiting version updates
2 parents 00fa069 + 40e80c5 commit c15d918

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/release-on-npm.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ jobs:
1515

1616
- name: Configure Git
1717
run: |
18-
git config --global user.email ""
19-
git config --global user.name "Symfony"
18+
git config --global user.email "41898282+github-actions[bot]@users.noreply.github.com"
19+
git config --global user.name "github-actions[bot]"
2020
2121
- name: Extract version from tag
2222
run: echo "VERSION=${GITHUB_REF#refs/tags/v}" >> $GITHUB_ENV

0 commit comments

Comments
 (0)