Skip to content

Commit a548681

Browse files
SanderVerkuilSander Verkuil
authored and
Sander Verkuil
committed
The TranslatorBag is no TranslatorInterface
Leverage union types to properly set up the configuration
1 parent 8219a2d commit a548681

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/Translator/src/CacheWarmer/TranslationsCacheWarmer.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
use Psr\Log\LoggerInterface;
1515
use Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerInterface;
1616
use Symfony\Component\Translation\TranslatorBagInterface;
17+
use Symfony\Contracts\Translation\TranslatorInterface;
1718
use Symfony\UX\Translator\TranslationsDumper;
1819

1920
/**
@@ -24,7 +25,7 @@
2425
class TranslationsCacheWarmer implements CacheWarmerInterface
2526
{
2627
public function __construct(
27-
private ?TranslatorBagInterface $translatorBag,
28+
private TranslatorInterface|TranslatorBagInterface|null $translatorBag,
2829
private TranslationsDumper $translationsDumper,
2930
private readonly ?LoggerInterface $logger = null,
3031
) {
@@ -37,7 +38,7 @@ public function isOptional(): bool
3738

3839
public function warmUp(string $cacheDir, ?string $buildDir = null): array
3940
{
40-
if (null === $this->translatorBag) {
41+
if (!$this->translatorBag instanceof TranslatorBagInterface) {
4142
$this->logger?->warning('Translator bag not available');
4243

4344
return [];

src/Translator/tests/CacheWarmer/TranslationsCacheWarmerTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
use PHPUnit\Framework\TestCase;
1515
use Psr\Log\LoggerInterface;
1616
use Symfony\Component\Translation\MessageCatalogue;
17+
use Symfony\Component\Translation\Translator;
1718
use Symfony\Component\Translation\TranslatorBag;
1819
use Symfony\UX\Translator\CacheWarmer\TranslationsCacheWarmer;
1920
use Symfony\UX\Translator\TranslationsDumper;

0 commit comments

Comments
 (0)