Skip to content

Commit 9b854dc

Browse files
committed
bug #640 [Live] Fixing bad copy paste internal name (weaverryan)
This PR was merged into the 2.x branch. Discussion ---------- [Live] Fixing bad copy paste internal name | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | None | License | MIT Definitely from a copy-and-paste error. That key is actually meaningless, since we specify the `name` key to choose a specific name: https://github.com/symfony/ux/blob/2.x/src/LiveComponent/assets/package.json#L12 I need to test, but after merge, when people update to this version, Flex should automatically update their `controllers.json` to remove the wrong key and add this one. Though, annoyingly, I'm sure this may still cause some trouble for some people - you'll likely at least need to restart Encore. Cheers! Commits ------- ed01fab [Live] Fixing bad copy paste internal name
2 parents 209e622 + ed01fab commit 9b854dc

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/LiveComponent/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# CHANGELOG
22

3+
## 2.8.0
4+
5+
- [BC BREAK]: The "key" used to load the controller in your `assets/controllers.json`
6+
file changed from `typed` to `live`. Update your `assets/controllers.json`
7+
file to change this key.
8+
39
## 2.7.0
410

511
- Added a new `route` parameter to `AsLiveComponent`, which allows to choose

src/LiveComponent/assets/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "MIT",
88
"symfony": {
99
"controllers": {
10-
"typed": {
10+
"live": {
1111
"main": "dist/live_controller.js",
1212
"name": "live",
1313
"webpackMode": "eager",

0 commit comments

Comments
 (0)