phpcs

Author: weaverryan

src/Chartjs/src/DependencyInjection/ChartjsExtension.php

@@ -20,8 +20,6 @@
 use Symfony\UX\Chartjs\Builder\ChartBuilder;
 use Symfony\UX\Chartjs\Builder\ChartBuilderInterface;
 use Symfony\UX\Chartjs\Twig\ChartExtension;
-use Symfony\UX\StimulusBundle\Dto\StimulusAttributes;
-use Twig\Environment;
 
 /**
  * @author Titouan Galopin <galopintitouan@gmail.com>

src/Chartjs/tests/ChartjsBundleTest.php

@@ -12,9 +12,6 @@
 namespace Symfony\UX\Chartjs\Tests;
 
 use PHPUnit\Framework\TestCase;
-use Symfony\Component\HttpKernel\Kernel;
-use Symfony\UX\Chartjs\Tests\Kernel\EmptyAppKernel;
-use Symfony\UX\Chartjs\Tests\Kernel\FrameworkAppKernel;
 use Symfony\UX\Chartjs\Tests\Kernel\TwigAppKernel;
 
 /**

src/Notify/src/Twig/NotifyRuntime.php

@@ -13,7 +13,6 @@
 
 use Symfony\Component\Mercure\HubInterface;
 use Symfony\UX\StimulusBundle\Helper\StimulusHelper;
-use Twig\Environment;
 use Twig\Extension\RuntimeExtensionInterface;
 
 /**

src/StimulusBundle/assets/controllers.ts

@@ -0,0 +1,9 @@
+// This file is dynamically rewritten by StimulusBundle + AssetMapper.
+/** @type {Object<string, Controller>} */
+export const eagerControllers = {};
+/** @type {Object<string, string>} */
+
+/** @type {Object<string, () => Promise<{default: Controller}>>} */
+export const lazyControllers = {};
+
+export const isApplicationDebug = false;

src/StimulusBundle/assets/loader.ts

@@ -0,0 +1,80 @@
+/**
+ * Starts the Stimulus application and reads a map dump in the DOM to load controllers.
+ *
+ * Inspired by stimulus-loading.js from stimulus-rails.
+ */
+import { Application } from '@hotwired/stimulus';
+import { eagerControllers, lazyControllers, isApplicationDebug } from './controllers.js';
+
+const controllerAttribute = 'data-controller';
+
+export const loadControllers = (application) => {
+    // loop over the controllers map and require each controller
+    for (const name in eagerControllers) {
+        registerController(name, eagerControllers[name], application);
+    }
+
+    loadLazyControllers(application);
+};
+
+export const startStimulusApp = () => {
+    const application = Application.start();
+    application.debug = isApplicationDebug;
+
+    loadControllers(application);
+
+    return application;
+};
+
+function registerController(name, controller, application) {
+    if (canRegisterController(name, application)) {
+        application.register(name, controller)
+    }
+}
+
+function loadLazyControllers(application) {
+    lazyLoadExistingControllers(application, document);
+    lazyLoadNewControllers(application, document)
+}
+
+function lazyLoadExistingControllers(application, element) {
+  queryControllerNamesWithin(element).forEach(controllerName => loadController(controllerName, application))
+}
+function queryControllerNamesWithin(element) {
+  return Array.from(element.querySelectorAll(`[${controllerAttribute}]`)).map(extractControllerNamesFrom).flat()
+}
+function extractControllerNamesFrom(element) {
+  return element.getAttribute(controllerAttribute).split(/\s+/).filter(content => content.length)
+}
+function lazyLoadNewControllers(application, element) {
+  new MutationObserver((mutationsList) => {
+    for (const { attributeName, target, type } of mutationsList) {
+      switch (type) {
+        case 'attributes': {
+          if (attributeName === controllerAttribute && target.getAttribute(controllerAttribute)) {
+            extractControllerNamesFrom(target).forEach(controllerName => loadController(controllerName, application))
+          }
+        }
+
+        case 'childList': {
+          lazyLoadExistingControllers(application, target)
+        }
+      }
+    }
+  }).observe(element, { attributeFilter: [controllerAttribute], subtree: true, childList: true })
+}
+function canRegisterController(name, application){
+  return !application.router.modulesByIdentifier.has(name)
+}
+
+async function loadController(name, application) {
+    if (canRegisterController(name, application)) {
+        if (lazyControllers[name] === undefined) {
+            console.error(`Failed to autoload controller: ${name}`);
+        }
+
+        const controllerModule = await (lazyControllers[name]());
+
+        registerController(name, controllerModule.default, application);
+    }
+}

src/StimulusBundle/config/services.php

@@ -9,6 +9,7 @@
 use Symfony\UX\StimulusBundle\Twig\StimulusTwigExtension;
 use Symfony\UX\StimulusBundle\Ux\UxPackageReader;
 use Twig\Environment;
+
 use function Symfony\Component\DependencyInjection\Loader\Configurator\abstract_arg;
 use function Symfony\Component\DependencyInjection\Loader\Configurator\param;
 use function Symfony\Component\DependencyInjection\Loader\Configurator\service;