|
| 1 | +--------------------------------------------------------------------------- |
| 2 | + |
| 3 | +by smnandre at 2024-09-11T21:39:36Z |
| 4 | + |
| 5 | +Hi @rrr63 ! Thank you for this PR |
| 6 | + |
| 7 | +Could you add just a screenshot or two, for other to understand what you're adding ? |
| 8 | + |
| 9 | +I'm wondering, you add on dragEnter, but you don't revert if the drag is canceled ? |
| 10 | + |
| 11 | +Also, it would be great to add a test or two :) |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | +--------------------------------------------------------------------------- |
| 16 | + |
| 17 | +by rrr63 at 2024-09-12T06:34:12Z |
| 18 | + |
| 19 | +Hi @smnandre , |
| 20 | + |
| 21 | +You're right, i canceled when the drag leaves, and added a test for both, enter and leave. |
| 22 | +Both, enter and leave are in the same test to get the right drag area from enter event. |
| 23 | + |
| 24 | +Demo : |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | +--------------------------------------------------------------------------- |
| 31 | + |
| 32 | +by smnandre at 2024-09-12T17:27:47Z |
| 33 | + |
| 34 | +Wow, thank you very much! I'll try tonight but this will probably more be this week-end :) |
| 35 | + |
| 36 | +--------------------------------------------------------------------------- |
| 37 | + |
| 38 | +by smnandre at 2024-09-12T17:31:45Z |
| 39 | + |
| 40 | +Could you add a entry in the CHANGELOG (inside the Dropzone folder) ? Next version will be 2.20 |
| 41 | + |
| 42 | +--------------------------------------------------------------------------- |
| 43 | + |
| 44 | +by rrr63 at 2024-09-12T18:36:43Z |
| 45 | + |
| 46 | +Sure i can, just copied the title :) |
| 47 | + |
0 commit comments