Skip to content

Commit 45770b0

Browse files
committed
bug #2154 [Dropzone] Enable file replacement via "drag-and-drop" (rrr63)
This PR was merged into the 2.x branch. Discussion ---------- [Dropzone] Enable file replacement via "drag-and-drop" | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Issues | Fix #1480 | License | MIT Adding `dragenter` event to allow file replacement Commits -------
1 parent ce483d7 commit 45770b0

File tree

2 files changed

+70
-0
lines changed

2 files changed

+70
-0
lines changed

.commit

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
bug #2154 [Dropzone] Enable file replacement via "drag-and-drop" (rrr63)
2+
3+
This PR was merged into the 2.x branch.
4+
5+
Discussion
6+
----------
7+
8+
[Dropzone] Enable file replacement via "drag-and-drop"
9+
10+
| Q | A
11+
| ------------- | ---
12+
| Bug fix? | yes
13+
| New feature? | no
14+
| Issues | Fix #1480
15+
| License | MIT
16+
17+
Adding `dragenter` event to allow file replacement
18+
19+
Commits
20+
-------
21+
22+
23+

.notes

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
---------------------------------------------------------------------------
2+
3+
by smnandre at 2024-09-11T21:39:36Z
4+
5+
Hi @rrr63 ! Thank you for this PR
6+
7+
Could you add just a screenshot or two, for other to understand what you're adding ?
8+
9+
I'm wondering, you add on dragEnter, but you don't revert if the drag is canceled ?
10+
11+
Also, it would be great to add a test or two :)
12+
13+
14+
15+
---------------------------------------------------------------------------
16+
17+
by rrr63 at 2024-09-12T06:34:12Z
18+
19+
Hi @smnandre ,
20+
21+
You're right, i canceled when the drag leaves, and added a test for both, enter and leave.
22+
Both, enter and leave are in the same test to get the right drag area from enter event.
23+
24+
Demo :
25+
![dropzone](https://github.com/user-attachments/assets/76143fdd-1dbc-4129-92f2-43e9780eed4b)
26+
27+
28+
29+
30+
---------------------------------------------------------------------------
31+
32+
by smnandre at 2024-09-12T17:27:47Z
33+
34+
Wow, thank you very much! I'll try tonight but this will probably more be this week-end :)
35+
36+
---------------------------------------------------------------------------
37+
38+
by smnandre at 2024-09-12T17:31:45Z
39+
40+
Could you add a entry in the CHANGELOG (inside the Dropzone folder) ? Next version will be 2.20
41+
42+
---------------------------------------------------------------------------
43+
44+
by rrr63 at 2024-09-12T18:36:43Z
45+
46+
Sure i can, just copied the title :)
47+

0 commit comments

Comments
 (0)