[StimulusBundle] Skip mapping .ts controller if .js version is available

Author: phasdev

src/StimulusBundle/src/AssetMapper/ControllersMapGenerator.php

@@ -70,13 +70,23 @@ private function loadCustomControllers(): array
 
         $controllersMap = [];
         foreach ($finder as $file) {
+
+            // Skip .ts controller if .js version is available
+            if ($file->getExtension() === 'ts' && file_exists(substr($file->getRealPath(), 0, -2) . "js")) {
+                continue;
+            }
+
             $name = $file->getRelativePathname();
             // use regex to extract 'controller'-postfix including extension
             preg_match(self::FILENAME_REGEX, $name, $matches);
             $name = str_replace(['_'.$matches[1], '-'.$matches[1]], '', $name);
             $name = str_replace(['_', '/', '\\'], ['-', '--', '--'], $name);
 
             $asset = $this->assetMapper->getAssetFromSourcePath($file->getRealPath());
+            if (!$asset) {
+                throw new \RuntimeException(\sprintf('Could not find an asset mapper path that points to the "%s" controller.', $name));
+            }
+
             $content = file_get_contents($asset->sourcePath);
             $isLazy = preg_match('/\/\*\s*stimulusFetch:\s*\'lazy\'\s*\*\//i', $content);
 

src/StimulusBundle/tests/AssetMapper/ControllersMapGeneratorTest.php

@@ -34,6 +34,8 @@ public function testGetControllersMap()
                     $logicalPath = 'fake-vendor/ux-package1/package-controller-second.js';
                 } elseif (str_ends_with($path, 'package-hello-controller.js')) {
                     $logicalPath = 'fake-vendor/ux-package2/package-hello-controller.js';
+                } elseif (str_ends_with($path, 'other-controller.ts')) {
+                    return null;
                 } else {
                     // replace windows slashes
                     $path = str_replace('\\', '/', $path);

src/StimulusBundle/tests/fixtures/assets/more-controllers/other-controller.ts

@@ -0,0 +1,7 @@
+// other-controller.js
+// @ts-ignore
+import { Controller } from '@hotwired/stimulus';
+
+/*    stimulusFetch:    'lazy'   */
+export default class extends Controller {
+}