[Serializer] Catch \Throwable in getCacheKey()

Author: dunglas

src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php

@@ -401,12 +401,26 @@ protected function createChildContext(array $parentContext, $attribute/*, string
     private function getCacheKey($format, array $context)
     {
         unset($context['cache_key']); // avoid artificially different keys
+
+        if (interface_exists(\Throwable::class)) {
+            try {
+                return md5($format.serialize([
+                        'context' => $context,
+                        'ignored' => $this->ignoredAttributes,
+                        'camelized' => $this->camelizedAttributes,
+                    ]));
+            } catch (\Throwable $exception) {
+                // The context cannot be serialized, skip the cache
+                return false;
+            }
+        }
+
         try {
             return md5($format.serialize([
-                'context' => $context,
-                'ignored' => $this->ignoredAttributes,
-                'camelized' => $this->camelizedAttributes,
-            ]));
+                    'context' => $context,
+                    'ignored' => $this->ignoredAttributes,
+                    'camelized' => $this->camelizedAttributes,
+                ]));
         } catch (\Exception $exception) {
             // The context cannot be serialized, skip the cache
             return false;

src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php

@@ -194,6 +194,13 @@ public function testExtraAttributesException()
             'allow_extra_attributes' => false,
         ]);
     }
+
+    public function testContextNotSerializable()
+    {
+        $normalizer = new ObjectNormalizer();
+        $result = $normalizer->normalize(new Dummy(), null, ['not_serializable' => new NotSerializable()]);
+        $this->assertIsArray($result);
+    }
 }
 
 class AbstractObjectNormalizerDummy extends AbstractObjectNormalizer
@@ -379,3 +386,15 @@ public function setSerializer(SerializerInterface $serializer)
         $this->serializer = $serializer;
     }
 }
+
+class NotSerializable
+{
+    function __sleep()
+    {
+        if (class_exists(\Error::class)) {
+            throw new \Error('not serializable');
+        }
+
+        throw new \Exception('not serializable');
+    }
+}