From 4c739b125ccc613e40e1c6205b1dd360515df44e Mon Sep 17 00:00:00 2001 From: Paul Ferrett Date: Sat, 1 Jul 2017 13:21:15 +1000 Subject: [PATCH] Update form best practises regarding Form::isValid --- best_practices/forms.rst | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/best_practices/forms.rst b/best_practices/forms.rst index a799d606ac4..489979c1862 100644 --- a/best_practices/forms.rst +++ b/best_practices/forms.rst @@ -204,7 +204,6 @@ and a ``createAction()`` that *only* processes the form submit. Both those actions will be almost identical. So it's much simpler to let ``newAction()`` handle everything. -Second, we recommend using ``$form->isSubmitted()`` in the ``if`` statement -for clarity. This isn't technically needed, since ``isValid()`` first calls -``isSubmitted()``. But without this, the flow doesn't read well as it *looks* -like the form is *always* processed (even on the GET request). +Second, is it required to call ``$form->isSubmitted()`` in the ``if`` statement +before calling ``isValid()``. Calling ``isValid()`` with an unsubmitted form +is deprecated since version 3.2 and will throw an exception in 4.0.