From 2afc79feea16316c6fc8e88402427b1fdf26e06c Mon Sep 17 00:00:00 2001 From: matthieu88160 Date: Wed, 8 Mar 2017 22:59:29 +0100 Subject: [PATCH 1/6] Improve specification explanation RFC 2616 and RFC 7234 define that a recipient MUST ignore Expires header if one of `s-max-age` or `max-age` header is defined. --- http_cache/expiration.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/http_cache/expiration.rst b/http_cache/expiration.rst index 9d1169a79a8..1e3a71ff59c 100644 --- a/http_cache/expiration.rst +++ b/http_cache/expiration.rst @@ -85,5 +85,11 @@ the lifetime calculation vulnerable to clock skew. Another limitation of the ``Expires`` header is that the specification states that "HTTP/1.1 servers should not send ``Expires`` dates more than one year in the future." +.. note:: + + Accordingly with `RFC 7234 - Caching`_, the `Expires` header value will be ignored by any recipient if a `s-max-age` or `max-age` header is defined. + + .. _`expiration model`: http://tools.ietf.org/html/rfc2616#section-13.2 .. _`FrameworkExtraBundle documentation`: https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/cache.html +.. _`RFC 7234 - Caching`: https://tools.ietf.org/html/rfc7234 From 96d1b84c1fa1cb5dadaf2bbe5231504179690e10 Mon Sep 17 00:00:00 2001 From: Javier Eguiluz Date: Mon, 13 Mar 2017 09:07:35 +0100 Subject: [PATCH 2/6] Minor reword and fixed the line length --- http_cache/expiration.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/http_cache/expiration.rst b/http_cache/expiration.rst index 1e3a71ff59c..81d0703ec3c 100644 --- a/http_cache/expiration.rst +++ b/http_cache/expiration.rst @@ -87,7 +87,8 @@ servers should not send ``Expires`` dates more than one year in the future." .. note:: - Accordingly with `RFC 7234 - Caching`_, the `Expires` header value will be ignored by any recipient if a `s-max-age` or `max-age` header is defined. + Accordingly with `RFC 7234 - Caching`_, the ``Expires`` header value is + ignored when a ``s-max-age`` or ``max-age`` header is defined. .. _`expiration model`: http://tools.ietf.org/html/rfc2616#section-13.2 From 3302f01cffe379ecb78266a8d690fb1242b9ab48 Mon Sep 17 00:00:00 2001 From: matthieu88160 Date: Mon, 13 Mar 2017 10:32:25 +0100 Subject: [PATCH 3/6] Update expiration.rst --- http_cache/expiration.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/http_cache/expiration.rst b/http_cache/expiration.rst index 81d0703ec3c..a5789ef5732 100644 --- a/http_cache/expiration.rst +++ b/http_cache/expiration.rst @@ -88,9 +88,9 @@ servers should not send ``Expires`` dates more than one year in the future." .. note:: Accordingly with `RFC 7234 - Caching`_, the ``Expires`` header value is - ignored when a ``s-max-age`` or ``max-age`` header is defined. + ignored when a ``s-max-age`` or ``max-age`` directives are defined. .. _`expiration model`: http://tools.ietf.org/html/rfc2616#section-13.2 .. _`FrameworkExtraBundle documentation`: https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/cache.html -.. _`RFC 7234 - Caching`: https://tools.ietf.org/html/rfc7234 +.. _`RFC 7234 - Caching`: https://tools.ietf.org/html/rfc7234#section-5.2 From 29e885c39eea8b447167bee08a64b5c6bdf46c13 Mon Sep 17 00:00:00 2001 From: matthieu88160 Date: Mon, 13 Mar 2017 10:34:59 +0100 Subject: [PATCH 4/6] Update expiration.rst --- http_cache/expiration.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/http_cache/expiration.rst b/http_cache/expiration.rst index a5789ef5732..d6674c466bb 100644 --- a/http_cache/expiration.rst +++ b/http_cache/expiration.rst @@ -93,4 +93,4 @@ servers should not send ``Expires`` dates more than one year in the future." .. _`expiration model`: http://tools.ietf.org/html/rfc2616#section-13.2 .. _`FrameworkExtraBundle documentation`: https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/cache.html -.. _`RFC 7234 - Caching`: https://tools.ietf.org/html/rfc7234#section-5.2 +.. _`RFC 7234 - Caching`: https://tools.ietf.org/html/rfc7234#section-4.2.1 From 32857d8e509f19af1e431a3aad7d443112157517 Mon Sep 17 00:00:00 2001 From: matthieu88160 Date: Mon, 13 Mar 2017 12:12:06 +0100 Subject: [PATCH 5/6] Update expiration.rst --- http_cache/expiration.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/http_cache/expiration.rst b/http_cache/expiration.rst index d6674c466bb..447d15d2dfc 100644 --- a/http_cache/expiration.rst +++ b/http_cache/expiration.rst @@ -88,7 +88,7 @@ servers should not send ``Expires`` dates more than one year in the future." .. note:: Accordingly with `RFC 7234 - Caching`_, the ``Expires`` header value is - ignored when a ``s-max-age`` or ``max-age`` directives are defined. + ignored when ``s-max-age`` or ``max-age`` directives are defined. .. _`expiration model`: http://tools.ietf.org/html/rfc2616#section-13.2 From 0d3243204ced0d22e9669c01305ac0c1761ce6bf Mon Sep 17 00:00:00 2001 From: matthieu88160 Date: Mon, 13 Mar 2017 12:56:52 +0100 Subject: [PATCH 6/6] Update expiration.rst --- http_cache/expiration.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/http_cache/expiration.rst b/http_cache/expiration.rst index 447d15d2dfc..d77e682b2a0 100644 --- a/http_cache/expiration.rst +++ b/http_cache/expiration.rst @@ -88,7 +88,7 @@ servers should not send ``Expires`` dates more than one year in the future." .. note:: Accordingly with `RFC 7234 - Caching`_, the ``Expires`` header value is - ignored when ``s-max-age`` or ``max-age`` directives are defined. + ignored when ``s-maxage`` or ``max-age`` directives are defined. .. _`expiration model`: http://tools.ietf.org/html/rfc2616#section-13.2