From 761f90a3251858528d426e90621121ac1e6b8a66 Mon Sep 17 00:00:00 2001 From: Edson Medina Date: Sun, 8 Feb 2015 14:11:31 +0000 Subject: [PATCH 1/3] Readability --- best_practices/configuration.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/best_practices/configuration.rst b/best_practices/configuration.rst index df9779b121e..b75a126cbcb 100644 --- a/best_practices/configuration.rst +++ b/best_practices/configuration.rst @@ -101,7 +101,7 @@ to control the number of posts to display on the blog homepage: parameters: homepage.num_items: 10 -If you ask yourself when the last time was that you changed the value of +If you ask yourself when was the last time you changed the value of *any* option like this, odds are that you *never* have. Creating a configuration option for a value that you are never going to configure just isn't necessary. Our recommendation is to define these values as constants in your application. From 24ec5e6a983bd0d6656936b1019becc4af585782 Mon Sep 17 00:00:00 2001 From: Edson Medina Date: Sun, 8 Mar 2015 13:54:00 +0000 Subject: [PATCH 2/3] Update configuration.rst --- best_practices/configuration.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/best_practices/configuration.rst b/best_practices/configuration.rst index b75a126cbcb..7b77b078a71 100644 --- a/best_practices/configuration.rst +++ b/best_practices/configuration.rst @@ -101,8 +101,8 @@ to control the number of posts to display on the blog homepage: parameters: homepage.num_items: 10 -If you ask yourself when was the last time you changed the value of -*any* option like this, odds are that you *never* have. Creating a configuration +If you've done something like this in the past, it's likely that you've in fact *never* actually needed +to change that value. Creating a configuration option for a value that you are never going to configure just isn't necessary. Our recommendation is to define these values as constants in your application. You could, for example, define a ``NUM_ITEMS`` constant in the ``Post`` entity: From e99b4a495da206d0872e59211ac45c50d0c32d10 Mon Sep 17 00:00:00 2001 From: Edson Medina Date: Sun, 8 Mar 2015 17:38:57 +0000 Subject: [PATCH 3/3] Update configuration.rst --- best_practices/configuration.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/best_practices/configuration.rst b/best_practices/configuration.rst index 7b77b078a71..dcd8f42e9f0 100644 --- a/best_practices/configuration.rst +++ b/best_practices/configuration.rst @@ -101,8 +101,8 @@ to control the number of posts to display on the blog homepage: parameters: homepage.num_items: 10 -If you've done something like this in the past, it's likely that you've in fact *never* actually needed -to change that value. Creating a configuration +If you've done something like this in the past, it's likely that you've in fact +*never* actually needed to change that value. Creating a configuration option for a value that you are never going to configure just isn't necessary. Our recommendation is to define these values as constants in your application. You could, for example, define a ``NUM_ITEMS`` constant in the ``Post`` entity: