From d4ba3c0aa6152ad19784e6eb21ebdebb66bda05f Mon Sep 17 00:00:00 2001 From: "Andrew M." Date: Tue, 4 Nov 2014 16:00:58 +0100 Subject: [PATCH 1/3] Fix typos in code --- cookbook/console/logging.rst | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/cookbook/console/logging.rst b/cookbook/console/logging.rst index 133021ccf7a..81be97e2aa5 100644 --- a/cookbook/console/logging.rst +++ b/cookbook/console/logging.rst @@ -205,11 +205,11 @@ First configure a listener for console terminate events in the service container xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> - Acme\DemoBundle\EventListener\ConsoleExceptionListener + Acme\DemoBundle\EventListener\ConsoleTerminateListener - + @@ -223,31 +223,31 @@ First configure a listener for console terminate events in the service container use Symfony\Component\DependencyInjection\Reference; $container->setParameter( - 'console_exception_listener.class', - 'Acme\DemoBundle\EventListener\ConsoleExceptionListener' + 'console_terminate_listener.class', + 'Acme\DemoBundle\EventListener\ConsoleTerminateListener' ); - $definitionConsoleExceptionListener = new Definition( - '%console_exception_listener.class%', + $definitionConsoleTerminateListener = new Definition( + '%console_terminate_listener.class%', array(new Reference('logger')) ); - $definitionConsoleExceptionListener->addTag( + $definitionConsoleTerminateListener->addTag( 'kernel.event_listener', array('event' => 'console.terminate') ); $container->setDefinition( 'kernel.listener.command_dispatch', - $definitionConsoleExceptionListener + $definitionConsoleTerminateListener ); Then implement the actual listener:: - // src/Acme/DemoBundle/EventListener/ConsoleExceptionListener.php + // src/Acme/DemoBundle/EventListener/ConsoleTerminateListener.php namespace Acme\DemoBundle\EventListener; use Symfony\Component\Console\Event\ConsoleTerminateEvent; use Psr\Log\LoggerInterface; - class ConsoleExceptionListener + class ConsoleTerminateListener { private $logger; From fc403b1439633c6629add091a3ace3862ca6613c Mon Sep 17 00:00:00 2001 From: "Andrew M." Date: Wed, 5 Nov 2014 11:17:51 +0100 Subject: [PATCH 2/3] Removed parameters from service --- cookbook/console/logging.rst | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/cookbook/console/logging.rst b/cookbook/console/logging.rst index 81be97e2aa5..5de937a3ffb 100644 --- a/cookbook/console/logging.rst +++ b/cookbook/console/logging.rst @@ -204,12 +204,8 @@ First configure a listener for console terminate events in the service container xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> - - Acme\DemoBundle\EventListener\ConsoleTerminateListener - - - + @@ -222,12 +218,8 @@ First configure a listener for console terminate events in the service container use Symfony\Component\DependencyInjection\Definition; use Symfony\Component\DependencyInjection\Reference; - $container->setParameter( - 'console_terminate_listener.class', - 'Acme\DemoBundle\EventListener\ConsoleTerminateListener' - ); $definitionConsoleTerminateListener = new Definition( - '%console_terminate_listener.class%', + 'Acme\DemoBundle\EventListener\ConsoleTerminateListener', array(new Reference('logger')) ); $definitionConsoleTerminateListener->addTag( From 2135b824946a4a0bdca38fd7ae419ac59f816f31 Mon Sep 17 00:00:00 2001 From: "Andrew M." Date: Tue, 18 Nov 2014 11:00:05 +0100 Subject: [PATCH 3/3] Change: ConsoleTerminateListener => ErrorLoggerListener --- cookbook/console/logging.rst | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/cookbook/console/logging.rst b/cookbook/console/logging.rst index 5de937a3ffb..61f54d3583c 100644 --- a/cookbook/console/logging.rst +++ b/cookbook/console/logging.rst @@ -190,7 +190,7 @@ First configure a listener for console terminate events in the service container # app/config/services.yml services: kernel.listener.command_dispatch: - class: Acme\DemoBundle\EventListener\ConsoleTerminateListener + class: Acme\DemoBundle\EventListener\ErrorLoggerListener arguments: logger: "@logger" tags: @@ -205,7 +205,7 @@ First configure a listener for console terminate events in the service container xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> - + @@ -218,28 +218,28 @@ First configure a listener for console terminate events in the service container use Symfony\Component\DependencyInjection\Definition; use Symfony\Component\DependencyInjection\Reference; - $definitionConsoleTerminateListener = new Definition( - 'Acme\DemoBundle\EventListener\ConsoleTerminateListener', + $definitionErrorLoggerListener = new Definition( + 'Acme\DemoBundle\EventListener\ErrorLoggerListener', array(new Reference('logger')) ); - $definitionConsoleTerminateListener->addTag( + $definitionErrorLoggerListener->addTag( 'kernel.event_listener', array('event' => 'console.terminate') ); $container->setDefinition( 'kernel.listener.command_dispatch', - $definitionConsoleTerminateListener + $definitionErrorLoggerListener ); Then implement the actual listener:: - // src/Acme/DemoBundle/EventListener/ConsoleTerminateListener.php + // src/Acme/DemoBundle/EventListener/ErrorLoggerListener.php namespace Acme\DemoBundle\EventListener; use Symfony\Component\Console\Event\ConsoleTerminateEvent; use Psr\Log\LoggerInterface; - class ConsoleTerminateListener + class ErrorLoggerListener { private $logger;