From 13b5645fb677037982fd0a58e383d0ad9e7cb8eb Mon Sep 17 00:00:00 2001 From: Tony Cosentino Date: Tue, 25 Mar 2014 19:58:56 +0100 Subject: [PATCH 1/6] Fixed event listeners priority --- reference/dic_tags.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/reference/dic_tags.rst b/reference/dic_tags.rst index 94fc8bac3f2..1ff949ac04b 100644 --- a/reference/dic_tags.rst +++ b/reference/dic_tags.rst @@ -460,9 +460,9 @@ To register your warmer with Symfony, give it the ``kernel.cache_warmer`` tag: ->addTag('kernel.cache_warmer', array('priority' => 0)) ; -The ``priority`` value is optional, and defaults to 0. This value can be -from -255 to 255, and the warmers will be executed in the order of their -priority. +The ``priority`` value is optional, and defaults to 0. The core Symfony +listeners priorities varies from -1024 to 1024, and the warmers will be +executed in the order of their priority. .. _dic-tags-kernel-event-listener: From db2c00206f8df2c5e618e529edd57b2585e8d6e2 Mon Sep 17 00:00:00 2001 From: Tony Cosentino Date: Tue, 25 Mar 2014 22:41:48 +0100 Subject: [PATCH 2/6] Fixed event listeners priority (typos after review) --- reference/dic_tags.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reference/dic_tags.rst b/reference/dic_tags.rst index 1ff949ac04b..2278b58c811 100644 --- a/reference/dic_tags.rst +++ b/reference/dic_tags.rst @@ -461,7 +461,7 @@ To register your warmer with Symfony, give it the ``kernel.cache_warmer`` tag: ; The ``priority`` value is optional, and defaults to 0. The core Symfony -listeners priorities varies from -1024 to 1024, and the warmers will be +listeners priorities vary from -1024 to 1024 and the warmers will be executed in the order of their priority. .. _dic-tags-kernel-event-listener: From 815f531546505abb5e2b64c42779aff38cff156d Mon Sep 17 00:00:00 2001 From: Tony Cosentino Date: Wed, 26 Mar 2014 17:38:38 +0100 Subject: [PATCH 3/6] Replaced the priority paragraph with a note and a table --- reference/dic_tags.rst | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/reference/dic_tags.rst b/reference/dic_tags.rst index 2278b58c811..341bf20cb4b 100644 --- a/reference/dic_tags.rst +++ b/reference/dic_tags.rst @@ -460,9 +460,23 @@ To register your warmer with Symfony, give it the ``kernel.cache_warmer`` tag: ->addTag('kernel.cache_warmer', array('priority' => 0)) ; -The ``priority`` value is optional, and defaults to 0. The core Symfony -listeners priorities vary from -1024 to 1024 and the warmers will be -executed in the order of their priority. +.. note:: + + The ``priority`` value is optional, and defaults to 0. + The higher the priority, the sooner it gets executed. + +kernel.cache_warmer +.............. + ++-------------------------------------------------------------------------------------------+-----------+ +| Cache Warmer Class Name | Priority | ++-------------------------------------------------------------------------------------------+-----------+ +| :class:`Symfony\\Bundle\\FrameworkBundle\\CacheWarmer\\TemplatePathsCacheWarmer` | 20 | ++-------------------------------------------------------------------------------------------+-----------+ +| :class:`Symfony\\Bundle\\FrameworkBundle\\CacheWarmer\\RouterCacheWarmer` | 0 | ++-------------------------------------------------------------------------------------------+-----------+ +| :class:`Symfony\\Bundle\\TwigBundle\\CacheWarmer\\TemplateCacheCacheWarmer` | 0 | ++-------------------------------------------------------------------------------------------+-----------+ .. _dic-tags-kernel-event-listener: From a9d07a5f1f05c83d9c35a58577070e1dcaad8f3f Mon Sep 17 00:00:00 2001 From: Tony Cosentino Date: Wed, 26 Mar 2014 17:54:13 +0100 Subject: [PATCH 4/6] Fixed title underline --- reference/dic_tags.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reference/dic_tags.rst b/reference/dic_tags.rst index 341bf20cb4b..e1ef0c2a316 100644 --- a/reference/dic_tags.rst +++ b/reference/dic_tags.rst @@ -466,7 +466,7 @@ To register your warmer with Symfony, give it the ``kernel.cache_warmer`` tag: The higher the priority, the sooner it gets executed. kernel.cache_warmer -.............. +................... +-------------------------------------------------------------------------------------------+-----------+ | Cache Warmer Class Name | Priority | From 1dbfd29bd5db50674d07262e544350c78a7e5bf7 Mon Sep 17 00:00:00 2001 From: Tony Cosentino Date: Wed, 26 Mar 2014 18:04:35 +0100 Subject: [PATCH 5/6] Updated title for the core cache warmers --- reference/dic_tags.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/reference/dic_tags.rst b/reference/dic_tags.rst index e1ef0c2a316..9880b2330d2 100644 --- a/reference/dic_tags.rst +++ b/reference/dic_tags.rst @@ -465,8 +465,8 @@ To register your warmer with Symfony, give it the ``kernel.cache_warmer`` tag: The ``priority`` value is optional, and defaults to 0. The higher the priority, the sooner it gets executed. -kernel.cache_warmer -................... +Core Cache Warmers +.................. +-------------------------------------------------------------------------------------------+-----------+ | Cache Warmer Class Name | Priority | From 47d4d4f6dc4d17b9328b856d49d79e02792fab23 Mon Sep 17 00:00:00 2001 From: Tony Cosentino Date: Thu, 27 Mar 2014 23:23:27 +0100 Subject: [PATCH 6/6] Fixed title level consistency --- reference/dic_tags.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reference/dic_tags.rst b/reference/dic_tags.rst index 9880b2330d2..dbd50a9f115 100644 --- a/reference/dic_tags.rst +++ b/reference/dic_tags.rst @@ -466,7 +466,7 @@ To register your warmer with Symfony, give it the ``kernel.cache_warmer`` tag: The higher the priority, the sooner it gets executed. Core Cache Warmers -.................. +~~~~~~~~~~~~~~~~~~ +-------------------------------------------------------------------------------------------+-----------+ | Cache Warmer Class Name | Priority |