From efbb0b3e534db74dbe1114e1e99993837eeb27c9 Mon Sep 17 00:00:00 2001 From: Loulier Guillaume Date: Tue, 4 Feb 2020 14:10:32 +0100 Subject: [PATCH 1/8] refacto(Lock): FlockStore default path --- components/lock.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/components/lock.rst b/components/lock.rst index 79ef3541ed0..235167662ec 100644 --- a/components/lock.rst +++ b/components/lock.rst @@ -227,6 +227,10 @@ PHP process is terminated:: // the argument is the path of the directory where the locks are created $store = new FlockStore(sys_get_temp_dir()); +.. note:: + + If no path is given, ``sys_get_temp_dir`` is used as default value. + .. caution:: Beware that some file systems (such as some types of NFS) do not support From a0a68bc6bdd33c20080825e8aa9f228184267081 Mon Sep 17 00:00:00 2001 From: Cassian Assael Date: Mon, 3 Feb 2020 17:46:32 +0100 Subject: [PATCH 2/8] fix: very_verbose mode shows estimated time --- components/console/helpers/progressbar.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/components/console/helpers/progressbar.rst b/components/console/helpers/progressbar.rst index 4a892603717..923a2bf9349 100644 --- a/components/console/helpers/progressbar.rst +++ b/components/console/helpers/progressbar.rst @@ -109,9 +109,9 @@ level of verbosity of the ``OutputInterface`` instance: 3/3 [============================] 100% 1 sec # OutputInterface::VERBOSITY_VERY_VERBOSE (-vv) - 0/3 [>---------------------------] 0% 1 sec - 1/3 [=========>------------------] 33% 1 sec - 3/3 [============================] 100% 1 sec + 0/3 [>---------------------------] 0% 1 sec/1 sec + 1/3 [=========>------------------] 33% 1 sec/1 sec + 3/3 [============================] 100% 1 sec/1 sec # OutputInterface::VERBOSITY_DEBUG (-vvv) 0/3 [>---------------------------] 0% 1 sec/1 sec 1.0 MB From 0a255dc002879ff3073f4eea7985321db47d982e Mon Sep 17 00:00:00 2001 From: Laurent VOULLEMIER Date: Sat, 25 Jan 2020 14:34:48 +0100 Subject: [PATCH 3/8] Fix compiler pass phase when extensions that implements CompilerPassInterface are executed --- components/dependency_injection/compilation.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/dependency_injection/compilation.rst b/components/dependency_injection/compilation.rst index 6a1db7d02bb..82d51f42cf6 100644 --- a/components/dependency_injection/compilation.rst +++ b/components/dependency_injection/compilation.rst @@ -341,7 +341,7 @@ methods described in :doc:`/service_container/definitions`. .. note:: Please note that the ``process()`` method in the extension class is - called during the optimization step. You can read + called during the ``PassConfig::TYPE_BEFORE_OPTIMIZATION`` step. You can read :ref:`the next section ` if you need to edit the container during another step. From 3ea0737e1441461d83e630cff7c94412676acf98 Mon Sep 17 00:00:00 2001 From: Oskar Stark Date: Wed, 5 Feb 2020 08:28:50 +0100 Subject: [PATCH 4/8] minor. refs #13042 --- components/lock.rst | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/components/lock.rst b/components/lock.rst index 235167662ec..49f412a8360 100644 --- a/components/lock.rst +++ b/components/lock.rst @@ -225,11 +225,8 @@ PHP process is terminated:: use Symfony\Component\Lock\Store\FlockStore; // the argument is the path of the directory where the locks are created - $store = new FlockStore(sys_get_temp_dir()); - -.. note:: - - If no path is given, ``sys_get_temp_dir`` is used as default value. + // if none is given, sys_get_temp_dir() is used internally. + $store = new FlockStore('/var/stores'); .. caution:: From b23187171027858aa4e05ed5eb9dc476c8f3437d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Deruss=C3=A9?= Date: Mon, 3 Feb 2020 21:32:16 +0100 Subject: [PATCH 5/8] Add caution in system+semaphore --- components/lock.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/components/lock.rst b/components/lock.rst index 49f412a8360..dd850167652 100644 --- a/components/lock.rst +++ b/components/lock.rst @@ -530,6 +530,14 @@ can be two running containers in parallel. concurrent process on a new machine, check that other process are stopped on the old one. +.. caution:: + + When runing on systemd with non-system user with option ``RemoveIPC=yes`` + (default value), locks are deleted by systemd when that user logs out. + Check that process is ran with a system user (UID <= SYS_UID_MAX) with + ``SYS_UID_MAX`` defined in ``/etc/login.defs``, or set the option + ``RemoveIPC=off`` in ``/etc/systemd/logind.conf``. + Overall ~~~~~~~ From 5fcedb6dabbaf6225cbb0ee7cd1bcad598ff3f95 Mon Sep 17 00:00:00 2001 From: Oskar Stark Date: Wed, 5 Feb 2020 08:40:54 +0100 Subject: [PATCH 6/8] minor. refs #13035 --- components/lock.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/lock.rst b/components/lock.rst index dd850167652..01331872cfa 100644 --- a/components/lock.rst +++ b/components/lock.rst @@ -532,9 +532,9 @@ can be two running containers in parallel. .. caution:: - When runing on systemd with non-system user with option ``RemoveIPC=yes`` + When runing on systemd with non-system user and option ``RemoveIPC=yes`` (default value), locks are deleted by systemd when that user logs out. - Check that process is ran with a system user (UID <= SYS_UID_MAX) with + Check that process is run with a system user (UID <= SYS_UID_MAX) with ``SYS_UID_MAX`` defined in ``/etc/login.defs``, or set the option ``RemoveIPC=off`` in ``/etc/systemd/logind.conf``. From 35d2e972002f3cb8735fa6736d6a784b99f6b98b Mon Sep 17 00:00:00 2001 From: Yanick Witschi Date: Thu, 6 Feb 2020 12:38:24 +0100 Subject: [PATCH 7/8] Added reasoning to autowiring in public bundles --- service_container/autowiring.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/service_container/autowiring.rst b/service_container/autowiring.rst index effbbea9856..504f6ec0258 100644 --- a/service_container/autowiring.rst +++ b/service_container/autowiring.rst @@ -506,6 +506,10 @@ Public and Reusable Bundles --------------------------- Public bundles should explicitly configure their services and not rely on autowiring. +Autowiring depends on the services that are available in the container and bundles have +no control over the service container of applications they are included in. You can use +autowiring when building reusable bundles within your company, as you have full control +over all code. .. _ROT13: https://en.wikipedia.org/wiki/ROT13 .. _service definition prototype: https://symfony.com/blog/new-in-symfony-3-3-psr-4-based-service-discovery From b96feb60d9a6bdc57f03a2ebf2f1828485addc25 Mon Sep 17 00:00:00 2001 From: BETARI Date: Wed, 27 Nov 2019 23:47:07 +0100 Subject: [PATCH 8/8] Update micro_kernel_trait.rst --- configuration/micro_kernel_trait.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configuration/micro_kernel_trait.rst b/configuration/micro_kernel_trait.rst index 3dabb98a436..3543ad4805f 100644 --- a/configuration/micro_kernel_trait.rst +++ b/configuration/micro_kernel_trait.rst @@ -32,7 +32,7 @@ Next, create an ``index.php`` file that creates a kernel class and executes it:: use Symfony\Component\Routing\RouteCollectionBuilder; // require Composer's autoloader - require __DIR__.'/vendor/autoload.php'; + require dirname(__DIR__).'/vendor/autoload.php'; class AppKernel extends Kernel {