Skip to content

Commit ff80230

Browse files
committed
minor #8415 Update 3.3-di-changes.rst (yceruto)
This PR was merged into the 3.3 branch. Discussion ---------- Update 3.3-di-changes.rst Now controllers tagged with `controller.service_arguments` are public `true` by definition symfony/symfony#24126 Commits ------- 33b0ab8 Update 3.3-di-changes.rst
2 parents ac619b4 + 33b0ab8 commit ff80230

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

service_container/3.3-di-changes.rst

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ Symfony Standard Edition:
5656
# and have a tag that allows actions to type-hint services
5757
AppBundle\Controller\:
5858
resource: '../../src/AppBundle/Controller'
59-
public: true
6059
tags: ['controller.service_arguments']
6160
6261
# add more services, or override services that need manual wiring
@@ -78,7 +77,7 @@ Symfony Standard Edition:
7877
7978
<prototype namespace="AppBundle\" resource="../../src/AppBundle/*" exclude="../../src/AppBundle/{Entity,Repository}" />
8079
81-
<prototype namespace="AppBundle\Controller\" resource="../../src/AppBundle/Controller" public="true">
80+
<prototype namespace="AppBundle\Controller\" resource="../../src/AppBundle/Controller">
8281
<tag name="controller.service_arguments" />
8382
</prototype>
8483
@@ -104,7 +103,6 @@ Symfony Standard Edition:
104103
105104
// Changes default config
106105
$definition
107-
->setPublic(true)
108106
->addTag('controller.service_arguments')
109107
;
110108
@@ -348,7 +346,6 @@ The third big change is that, in a new Symfony 3.3 project, your controllers are
348346
# and have a tag that allows actions to type-hint services
349347
AppBundle\Controller\:
350348
resource: '../../src/AppBundle/Controller'
351-
public: true
352349
tags: ['controller.service_arguments']
353350
354351
.. code-block:: xml
@@ -363,7 +360,7 @@ The third big change is that, in a new Symfony 3.3 project, your controllers are
363360
<services>
364361
<!-- ... -->
365362
366-
<prototype namespace="AppBundle\Controller\" resource="../../src/AppBundle/Controller" public="true">
363+
<prototype namespace="AppBundle\Controller\" resource="../../src/AppBundle/Controller">
367364
<tag name="controller.service_arguments" />
368365
</prototype>
369366
</services>
@@ -375,9 +372,6 @@ The third big change is that, in a new Symfony 3.3 project, your controllers are
375372
376373
// ...
377374
378-
// override default template
379-
$definition->setPublic(true);
380-
381375
$this->registerClasses($definition, 'AppBundle\\Controller\\', '../../src/AppBundle/Controller/*');
382376
383377
But, you might not even notice this. First, your controllers *can* still extend
@@ -676,7 +670,6 @@ You're now ready to automatically register all services in ``src/AppBundle/``
676670
+
677671
+ AppBundle\Controller\:
678672
+ resource: '../../src/AppBundle/Controller'
679-
+ public: true
680673
+ tags: ['controller.service_arguments']
681674
682675
# ...
@@ -766,7 +759,6 @@ can be autowired. The final configuration looks like this:
766759
767760
AppBundle\Controller\:
768761
resource: '../../src/AppBundle/Controller'
769-
public: true
770762
tags: ['controller.service_arguments']
771763
772764
AppBundle\Service\GitHubNotifier:

0 commit comments

Comments
 (0)