Skip to content

Commit f7948d8

Browse files
committed
minor #16799 [Security] Correcting bugs for provider and JSON login (KosticDusan4D)
This PR was merged into the 6.0 branch. Discussion ---------- [Security] Correcting bugs for provider and JSON login On lines 501 and 502 I propose this change, because it confused me so much which provider to use, and in the case that you are explaining there you should use earlier configured app_user_provider, not users_in_memory. On line 1043 I had a problem that $user is always null until I deleted the "?User" from parameters. I think that PHP gets confused here with the way it is written. And to say that now with that part removed everything works fine. Thanks in advance and I hope that I contributed even a little as this is. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 2309b0b Correcting bugs for provider and JSON login
2 parents 2bbc0c9 + 2309b0b commit f7948d8

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

security.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,8 @@ will be able to authenticate (e.g. login form, API token, etc).
486486
security: false
487487
main:
488488
lazy: true
489-
provider: users_in_memory
489+
# provider that you set earlier inside providers
490+
provider: app_user_provider
490491
491492
# activate different ways to authenticate
492493
# https://symfony.com/doc/current/security.html#firewalls-authentication

0 commit comments

Comments
 (0)