You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
minor #17212 [Routing] Adding full example for a Service in Route Condition (ThomasLandauer)
This PR was squashed before being merged into the 6.1 branch.
Discussion
----------
[Routing] Adding full example for a Service in Route Condition
Reasons:
* There needs to be an example on how to pass any information to this callback service. I merely *guessed* the `route` syntax - it's not even explained at https://symfony.com/blog/new-in-symfony-6-1-services-in-route-conditions - is there a better way to do it?
* How to call a method from this service wasn't explained (the `.check()` part)
* This method needs to return `bool`?
I don't think it's a good idea to add those code blocks inside this indented "list" - will it even work? So probably it's better to create a dedicated paragraph (or even heading) for Services in Route Conditions. But you need to tell me how (i.e. what structure you have in mind).
Commits
-------
4e72ef3 [Routing] Adding full example for a Service in Route Condition
0 commit comments