Merge branch '3.4'

* 3.4: (32 commits)
  [#8185] minor reword
  [#8211] minor reword
  Reword
  Update language.rst
  Mention lazy loading for Doctrine event listeners
  Documented the WebProfilerBundle configuration
  Added a note about the new behavior of BrowserKit and redirects
  Fixed usage of default configuration in PHP
  Some typos
  Add pipe to dump command
  Update event_dispatcher.rst
  Typo fixed in a doctrine docs
  [#8245] link text directly
  Link to '"creating a reproducer" in "reporting a bug"
  Removed an extra line
  Updated xml config
  applying comment from @wouterj
  [Form] [RepeatedType] Update "type" default value
  Adds a missing semicolon
  Added missing "," in encore/legacy-apps doc
  ...

Author: xabbuh

components/cache/cache_pools.rst

@@ -121,3 +121,20 @@ when all items are successfully deleted)::
 
     // ...
     $cacheIsEmpty = $cache->clear();
+
+.. tip::
+
+    If the Cache component is used inside a Symfony application, you can remove
+    all the items of a given cache pool with the following command:
+
+    .. code-block:: terminal
+
+        $ php bin/console cache:pool:clear <cache-pool-name>
+        
+        # clears the "cache.app" pool
+        $ php bin/console cache:pool:clear cache.app
+
+        # clears the "cache.validation" and "cache.app" pool
+        $ php bin/console cache:pool:clear cache.validation cache.app
+
+.. _`Doctrine Cache`: https://github.com/doctrine/cache

components/event_dispatcher.rst

@@ -497,8 +497,7 @@ with some other dispatchers:
 
 * :doc:`/components/event_dispatcher/container_aware_dispatcher`
 * :doc:`/components/event_dispatcher/immutable_dispatcher`
-* :doc:`/components/event_dispatcher/traceable_dispatcher` (provided by the
-  :doc:`HttpKernel component </components/http_kernel>`)
+* :doc:`/components/event_dispatcher/traceable_dispatcher`
 
 Learn More
 ----------

components/form.rst

@@ -476,8 +476,8 @@ builder:
                 );
 
                 $form = $this->createFormBuilder($defaults)
-		    ->add('task', TextType::class)
-		    ->add('dueDate', DateType::class)
+                    ->add('task', TextType::class)
+                    ->add('dueDate', DateType::class)
                     ->getForm();
 
                 // ...
@@ -616,8 +616,8 @@ method:
             public function newAction(Request $request)
             {
                 $form = $this->createFormBuilder()
-		    ->add('task', TextType::class)
-		    ->add('dueDate', DateType::class)
+                    ->add('task', TextType::class)
+                    ->add('dueDate', DateType::class)
                     ->getForm();
 
                 $form->handleRequest($request);
@@ -694,10 +694,10 @@ option when building each field:
             public function newAction(Request $request)
             {
                 $form = $this->createFormBuilder()
-		    ->add('task', TextType::class, array(
+                    ->add('task', TextType::class, array(
                         'constraints' => new NotBlank(),
                     ))
-		    ->add('dueDate', DateType::class, array(
+                    ->add('dueDate', DateType::class, array(
                         'constraints' => array(
                             new NotBlank(),
                             new Type(\DateTime::class),

contributing/code/bugs.rst

@@ -26,9 +26,9 @@ If your problem definitely looks like a bug, report it using the official bug
 * Describe the steps needed to reproduce the bug with short code examples
   (providing a unit test that illustrates the bug is best);
 
-* If the bug you experienced affects more than one layer, providing a simple
-  failing unit test may not be sufficient. In this case, please fork the
-  `Symfony Standard Edition`_ and reproduce your issue on a new branch;
+* If the bug you experienced is not obvious or affects more than one layer, 
+  providing a simple failing unit test may not be sufficient. In this case, 
+  please :doc:`provide a reproducer </contributing/code/reproducer>`;
 
 * Give as much detail as possible about your environment (OS, PHP version,
   Symfony version, enabled extensions, ...);

doctrine.rst

@@ -527,7 +527,7 @@ a controller, this is pretty easy. Add the following method to the
     {
         $doctrine = $this->getDoctrine();
         $em = $doctrine->getManager();
-        $em2 = $doctrine->getManager('other_connection')
+        $em2 = $doctrine->getManager('other_connection');
     }
 
 .. note::
@@ -680,7 +680,7 @@ Updating an Object
 Once you've fetched an object from Doctrine, updating it is easy. Suppose
 you have a route that maps a product id to an update action in a controller::
 
-    use AppBundle\Entity\Post;
+    use AppBundle\Entity\Product;
     // ...
 
     public function updateAction($productId)

doctrine/event_listeners_subscribers.rst

@@ -185,5 +185,58 @@ interface and have an event method for each event it subscribes to::
 
 For a full reference, see chapter `The Event System`_ in the Doctrine documentation.
 
+Lazy loading for Event Listeners
+--------------------------------
+
+One subtle difference between listeners and subscribers is that Symfony can load 
+entity listeners lazily. This means that your listener class will only be fetched
+from the service container (and thus be instantiated) once the event it is linked
+to actually fires.
+
+Lazy loading might give you a slight performance improvement when your listener 
+runs for events that rarely fire. Also, it can help you when you run into 
+*circular dependency issues* that may occur when your listener service in turn
+depends on the DBAL connection. 
+
+To mark a listener service as lazily loaded, just add the ``lazy`` attribute
+to the tag like so:
+
+.. configuration-block::
+
+    .. code-block:: yaml
+
+        services:
+            my.listener:
+                class: AppBundle\EventListener\SearchIndexer
+                tags:
+                    - { name: doctrine.event_listener, event: postPersist, lazy: true }
+
+    .. code-block:: xml
+
+        <?xml version="1.0" ?>
+        <container xmlns="http://symfony.com/schema/dic/services"
+            xmlns:doctrine="http://symfony.com/schema/dic/doctrine">
+
+            <services>
+                <service id="my.listener" class="AppBundle\EventListener\SearchIndexer">
+                    <tag name="doctrine.event_listener" event="postPersist" lazy="true" />
+                </service>
+            </services>
+        </container>
+
+    .. code-block:: php
+
+        use AppBundle\EventListener\SearchIndexer;
+
+        $container
+            ->register('my.listener', SearchIndexer::class)
+            ->addTag('doctrine.event_listener', array('event' => 'postPersist', 'lazy' => 'true'))
+        ;
+
+.. note::
+
+    Marking an event listener as ``lazy`` has nothing to do with lazy service
+    definitions which are described :doc:`in their own section </service_container/lazy_services>`
+
 .. _`The Event System`: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/events.html
 .. _`the Doctrine Documentation`: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/events.html#entity-listeners

form/create_custom_field_type.rst

@@ -6,10 +6,9 @@ How to Create a Custom Form Field Type
 
 Symfony comes with a bunch of core field types available for building forms.
 However there are situations where you may want to create a custom form field
-type for a specific purpose. This recipe assumes you need a field definition
+type for a specific purpose. This article assumes you need a field definition
 that holds a shipping option, based on the existing choice field. This section
-explains how the field is defined, how you can customize its layout and finally,
-how you can register it for use in your application.
+explains how the field is defined and how you can customize its layout.
 
 Defining the Field Type
 -----------------------

frontend/encore/legacy-apps.rst

@@ -52,7 +52,7 @@ method from Encore. In practice, it's equivalent to doing:
         // such as '_' for the 'underscore' library
         .autoProvideVariables({
             $: 'jquery',
-            jQuery: 'jquery'
+            jQuery: 'jquery',
             'window.jQuery': 'jquery',
         })
         // ...

reference/configuration/debug.rst

@@ -19,6 +19,7 @@ Configuration
 -------------
 
 * `max_items`_
+* `min_depth`_
 * `max_string_length`_
 * `dump_destination`_
 
@@ -30,6 +31,19 @@ max_items
 This is the maximum number of items to dump. Setting this option to ``-1``
 disables the limit.
 
+min_depth
+~~~~~~~~~
+
+**type**: ``integer`` **default**: ``1``
+
+Configures the minimum tree depth until which all items are guaranteed to
+be cloned. After this depth is reached, only ``max_items`` items will be
+cloned. The default value is ``1``, which is consistentcwith older Symfony
+versions.
+
+.. versionadded:: 3.4
+    The ``min_depth`` option was introduced in Symfony 3.4.
+
 max_string_length
 ~~~~~~~~~~~~~~~~~
 

reference/configuration/twig.rst

@@ -55,6 +55,16 @@ TwigBundle Configuration ("twig")
             paths:
                 '%kernel.project_dir%/vendor/acme/foo-bar/templates': foo_bar
 
+            # The following were added in Symfony 2.7.
+            date:
+                format: d.m.Y, H:i:s
+                interval_format: '%%d days'
+                timezone: Asia/Tokyo
+            number_format:
+                decimals: 2
+                decimal_point: ','
+                thousands_separator: '.'
+
     .. code-block:: xml
 
         <!-- app/config/config.xml -->
@@ -81,6 +91,9 @@ TwigBundle Configuration ("twig")
 
                 <twig:global key="foo" id="bar" type="service" />
                 <twig:global key="pi">3.14</twig:global>
+                
+                <twig:date format="d.m.Y, H:i:s" interval-format="%d days" timezone="Asia/Tokyo" />
+                <twig:number-format decimals="2" decimal-point="," thousands-separator="." />
 
                 <twig:exception-controller>AcmeFooBundle:Exception:showException</twig:exception-controller>
                 <twig:path namespace="foo_bar">%kernel.project_dir%/vendor/acme/foo-bar/templates</twig:path>
@@ -111,6 +124,16 @@ TwigBundle Configuration ("twig")
              'paths' => array(
                  '%kernel.project_dir%/vendor/acme/foo-bar/templates' => 'foo_bar',
              ),
+            'date' => array(
+                'format' => 'd.m.Y, H:i:s',
+                'interval_format' => '%%d days',
+                'timezone' => 'Asia/Tokyo',
+            ),
+            'number_format' => array(
+                'decimals' => 2,
+                'decimal_point' => ',',
+                'thousands_separator' => '.',
+            ),
         ));
 
 .. caution::
@@ -210,6 +233,37 @@ charset
 The charset used by the template files. In the Symfony Standard edition this
 defaults to the ``UTF-8`` charset.
 
+date
+~~~~
+
+These options define the default values used by the ``date`` filter to format
+date and time values. They are useful to avoid passing the same arguments on
+every ``date`` filter call.
+
+format
+......
+
+**type**: ``string`` **default**: ``F j, Y H:i``
+
+The format used by the ``date`` filter to display values when no specific format
+is passed as argument.
+
+internal_format
+...............
+
+**type**: ``string`` **default**: ``%d days``
+
+The format used by the ``date`` filter to display ``DateInterval`` instances
+when no specific format is passed as argument.
+
+timezone
+........
+
+**type**: ``string`` **default**: (the value returned by ``date_default_timezone_get()``)
+
+The timezone used when formatting date values with the ``date`` filter and no
+specific timezone is passed as argument.
+
 debug
 ~~~~~
 
@@ -234,6 +288,38 @@ option is advanced. If you need to customize an error page you should use
 the previous link. If you need to perform some behavior on an exception,
 you should add a listener to the ``kernel.exception`` event (see :ref:`dic-tags-kernel-event-listener`).
 
+number_format
+~~~~~~~~~~~~~
+
+These options define the default values used by the ``number_format`` filter to
+format numeric values. They are useful to avoid passing the same arguments on
+every ``number_format`` filter call.
+
+decimals
+........
+
+**type**: ``integer`` **default**: ``0``
+
+The number of decimals used to format numeric values when no specific number is
+passed as argument to the ``number_format`` filter.
+
+decimal_point
+.............
+
+**type**: ``string`` **default**: ``.``
+
+The character used to separate the decimals from the integer part of numeric
+values when no specific character is passed as argument to the ``number_format``
+filter.
+
+thousands_separator
+...................
+
+**type**: ``string`` **default**: ``,``
+
+The character used to separate every group of thousands in numeric values when
+no specific character is passed as argument to the ``number_format`` filter.
+
 optimizations
 ~~~~~~~~~~~~~