Skip to content

Commit b9ab0b5

Browse files
committed
Merge branch '3.4' into 4.2
* 3.4: removed obsolete versionadded-directive Minor "Review comments" tweaks use correct code-block removed versionadded, fixed count and note which behaves like versionadded
2 parents 8f66dbb + 411e9d2 commit b9ab0b5

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

contributing/community/review-comments.rst

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -91,34 +91,34 @@ Don't use hyperbole ("always", "never", "endlessly", "nothing", "worst", "horrib
9191
**Don't:** *"I don't like how you wrote this code"* - there is no clear explanation why you
9292
don't like how it's written.
9393

94-
**Better:** *"I find it hard to read this code as there many nested if statements, can you make it more
95-
readable? By encapsulating some of it's details or maybe adding some comments to explain the overall logic."* -
94+
**Better:** *"I find it hard to read this code as there is many nested if statements, can you make it more
95+
readable? By encapsulating some of its details or maybe adding some comments to explain the overall logic."* -
9696
You explain why you find the code hard to read *and* give some suggestions for improvement.
9797

9898
If a piece of code is in fact wrong, explain why:
9999

100-
* ``This code doesn't comply with Symfony's CS rules. Please see [...] for details``.
100+
* "This code doesn't comply with Symfony's CS rules. Please see [...] for details."
101101

102-
* ``Symfony 3 still uses PHP 5 and doesn't allow the usage scalar type-hints.``.
102+
* "Symfony 3 still uses PHP 5 and doesn't allow the usage scalar type-hints."
103103

104-
* ``I think the code is less readable now`` - careful here, be sure explain why you think
104+
* "I think the code is less readable now." - careful here, be sure explain why you think
105105
the code is less readable, and maybe give some suggestions?
106106

107107
**Examples of valid reasons to reject:**
108108

109-
* We tried that in the past (link to the relevant PR) but we needed to revert it for XXX reason.
109+
* "We tried that in the past (link to the relevant PR) but we needed to revert it for XXX reason."
110110

111-
* That change would introduce too many merge conflicts when merging up Symfony branches.
112-
In the past we've always rejected changes like this.
111+
* "That change would introduce too many merge conflicts when merging up Symfony branches.
112+
In the past we've always rejected changes like this."
113113

114-
* I profiled this change and it hurts performance significantly (if you don't profile, it's an opinion, so we can ignore)
114+
* "I profiled this change and it hurts performance significantly" - if you don't profile, it's an opinion, so we can ignore
115115

116-
* Code doesn't match Symfony's CS rules (e.g. use ``[]`` instead of ``array()``)
116+
* "Code doesn't match Symfony's CS rules (e.g. use ``[]`` instead of ``array()``)"
117117

118-
* We only provide integration with very popular projects (e.g. we integrate Bootstrap but not your own CSS framework)
118+
* "We only provide integration with very popular projects (e.g. we integrate Bootstrap but not your own CSS framework)"
119119

120-
* This would require adding lots of code and making lots of changes for a feature that doesn't look so important.
121-
That could hurt maintaining in the future.
120+
* "This would require adding lots of code and making lots of changes for a feature that doesn't look so important.
121+
That could hurt maintaining in the future."
122122

123123
Asking for Changes
124124
------------------

controller/argument_value_resolver.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ functionality.
1515
Functionality Shipped with the HttpKernel
1616
-----------------------------------------
1717

18-
Symfony ships with five value resolvers in the HttpKernel component:
18+
Symfony ships with the following value resolvers in the HttpKernel component:
1919

2020
:class:`Symfony\\Component\\HttpKernel\\Controller\\ArgumentResolver\\RequestAttributeValueResolver`
2121
Attempts to find a request attribute that matches the name of the argument.

workflow/usage.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ of domain logic in your templates:
438438

439439
The following example shows these functions in action:
440440

441-
.. code-block:: twig
441+
.. code-block:: html+twig
442442

443443
<h3>Actions</h3>
444444
{% if workflow_can(post, 'publish') %}

0 commit comments

Comments
 (0)