Merge branch '3.4' into 4.0

* 3.4:
  Fix missing trailling commas
  [Serializer] Added missing ObjectNormalizer
  [Serializer] By default the serializer do not convert to lower case properties
  Added a note about named form types
  Update translation.rst
  minor #8310 [DI] add docs for new namespace option (kbond, javiereguiluz)
  Added a note about controller arguments
  Documented the new behavior of getGroupSequence() method
  Fix UrlMatcher::match() URL
  Updated a diagram to SVG format

Author: javiereguiluz

_images/security/authentication-guard-methods.png

@@ -462,7 +462,7 @@ Pass an array of values::
     // sets multiple fields at once
     $form->setValues(array('multi' => array(
         1             => 'value',
-        'dimensional' => 'an other value'
+        'dimensional' => 'an other value',
     )));
 
 This is great, but it gets better! The ``Form`` object allows you to interact

_images/security/authentication-guard-methods.svg

@@ -62,7 +62,7 @@ URL path and some array of custom variables in its constructor. This array
 of custom variables can be *anything* that's significant to your application,
 and is returned when that route is matched.
 
-The :method:`UrlMatcher::match() <Symfony\\Component\\Routing\\UrlMatcher::match>`
+The :method:`UrlMatcher::match() <Symfony\\Component\\Routing\\Matcher\\UrlMatcher::match>`
 returns the variables you set on the route as well as the wildcard placeholders
 (see below). Your application can now use this information to continue
 processing the request. In addition to the configured variables, a ``_route``

_images/sources/security/authentication-guard-methods.dia

@@ -550,9 +550,10 @@ There are several types of normalizers available:
     directly and through getters, setters, hassers, adders and removers. It supports
     calling the constructor during the denormalization process.
 
-    Objects are normalized to a map of property names (method name stripped of
-    the "get"/"set"/"has"/"remove" prefix and converted to lower case) to property
-    values.
+    Objects are normalized to a map of property names and values (names are
+    generated removing the ``get``, ``set``, ``has`` or ``remove`` prefix from
+    the method name and lowercasing the first letter; e.g. ``getFirstName()`` ->
+    ``firstName``).
 
     The ``ObjectNormalizer`` is the most powerful normalizer. It is configured by
     default when using the Symfony Standard Edition with the serializer enabled.
@@ -562,8 +563,9 @@ There are several types of normalizers available:
     (public methods starting with "get"). It will denormalize data by calling
     the constructor and the "setters" (public methods starting with "set").
 
-    Objects are normalized to a map of property names (method name stripped of
-    the "get" prefix and converted to lower case) to property values.
+    Objects are normalized to a map of property names and values (names are
+    generated removing the ``get`` prefix from the method name and lowercasing
+    the first letter; e.g. ``getFirstName()`` -> ``firstName``).
 
 :class:`Symfony\\Component\\Serializer\\Normalizer\\PropertyNormalizer`
     This normalizer directly reads and writes public properties as well as
@@ -681,7 +683,8 @@ Circular references are common when dealing with entity relations::
     }
 
 To avoid infinite loops, :class:`Symfony\\Component\\Serializer\\Normalizer\\GetSetMethodNormalizer`
-throws a :class:`Symfony\\Component\\Serializer\\Exception\\CircularReferenceException`
+or :class:`Symfony\\Component\\Serializer\\Normalizer\\ObjectNormalizer`
+throw a :class:`Symfony\\Component\\Serializer\\Exception\\CircularReferenceException`
 when such a case is encountered::
 
     $member = new Member();

components/dom_crawler.rst

@@ -34,9 +34,8 @@ The constructor of the ``Translator`` class needs one argument: The locale.
 .. code-block:: php
 
     use Symfony\Component\Translation\Translator;
-    use Symfony\Component\Translation\MessageSelector;
 
-    $translator = new Translator('fr_FR', new MessageSelector());
+    $translator = new Translator('fr_FR');
 
 .. note::
 

components/routing.rst

@@ -369,7 +369,6 @@ of your commands to change their appearance::
 
             // After
             $io = new CustomStyle($input, $output);
-
             // ...
         }
     }

components/serializer.rst

@@ -78,7 +78,7 @@ managers that use this connection.
         $container->autowire(SearchIndexer2::class)
             ->addTag('doctrine.event_listener', array(
                 'event' => 'postPersist',
-                'connection' => 'default'
+                'connection' => 'default',
             ))
         ;
         $container->autowire(SearchIndexerSubscriber::class)

components/translation.rst

@@ -54,7 +54,7 @@ this spool, use the following configuration:
         // config/packages/swiftmailer.php
         $container->loadFromExtension('swiftmailer', array(
              // ...
-            'spool' => array('type' => 'memory')
+            'spool' => array('type' => 'memory'),
         ));
 
 .. _spool-using-a-file:

console/style.rst

@@ -106,7 +106,7 @@ for that::
         public function configureOptions(OptionsResolver $resolver)
         {
             $resolver->setDefaults(array(
-                'inherit_data' => true
+                'inherit_data' => true,
             ));
         }
     }

doctrine/event_listeners_subscribers.rst

@@ -699,6 +699,13 @@ the choice is ultimately up to you.
 
         $form->get('agreeTerms')->setData(true);
 
+
+.. note::
+
+    The form name is automatically generated from the type class name. If you want
+    to modify it, use the :method:`Symfony\\Component\\Form\\FormFactoryInterface::createNamed` method.
+    You can even suppress the name completely by setting it to an empty string.
+
 Final Thoughts
 --------------
 

email/spool.rst

@@ -218,7 +218,7 @@ exposing a simple and efficient pattern::
             // or render a template with the $response you've already started
             return $this->render('article/show.html.twig', array(
                 'article' => $article,
-                'comments' => $comments
+                'comments' => $comments,
             ), $response);
         }
     }

form/inherit_data_option.rst

@@ -1408,7 +1408,7 @@ configure this like:
             'templating' => array(
                 'form' => array(
                     'resources' => array(
-                        'form_themes'
+                        'form_themes',
                     ),
                 ),
             ),

forms.rst

@@ -720,11 +720,11 @@ multiple firewalls, the "context" could actually be shared:
             'firewalls' => array(
                 'somename' => array(
                     // ...
-                    'context' => 'my_context'
+                    'context' => 'my_context',
                 ),
                 'othername' => array(
                     // ...
-                    'context' => 'my_context'
+                    'context' => 'my_context',
                 ),
             ),
         ));

http_cache/validation.rst

@@ -89,7 +89,7 @@ on an object that will contain a credit card number.
             {
                 $metadata->addPropertyConstraint('cardNumber', new Assert\CardScheme(array(
                     'schemes' => array(
-                        'VISA'
+                        'VISA',
                     ),
                     'message' => 'Your credit card number is invalid.',
                 )));

reference/configuration/framework.rst

@@ -89,7 +89,7 @@ on an object that will contain an ISBN.
             {
                 $metadata->addPropertyConstraint('isbn', new Assert\Isbn(array(
                     'type'    => 'isbn10',
-                    'message' => 'This value is not valid.'
+                    'message' => 'This value is not valid.',
                 )));
             }
         }

reference/configuration/security.rst

@@ -59,10 +59,10 @@ address as its own input text box::
 
     $builder->add('emails', CollectionType::class, array(
         // each entry in the array will be an "email" field
-        'entry_type'   => EmailType::class,
+        'entry_type' => EmailType::class,
         // these options are passed to each "email" type
-        'entry_options'  => array(
-            'attr'      => array('class' => 'email-box')
+        'entry_options' => array(
+            'attr' => array('class' => 'email-box'),
         ),
     ));
 

reference/constraints/CardScheme.rst

@@ -152,7 +152,7 @@ values for the year, month and day fields::
 
     $builder->add('dueDate', DateType::class, array(
         'placeholder' => array(
-            'year' => 'Year', 'month' => 'Month', 'day' => 'Day'
+            'year' => 'Year', 'month' => 'Month', 'day' => 'Day',
         )
     ));
 

reference/constraints/Isbn.rst

@@ -20,7 +20,7 @@ Take the following example::
             'now' => new \DateTime('now'),
             'tomorrow' => new \DateTime('+1 day'),
             '1 week' => new \DateTime('+1 week'),
-            '1 month' => new \DateTime('+1 month')
+            '1 month' => new \DateTime('+1 month'),
         ),
         'group_by' => function($val, $key, $index) {
             if ($val <= new \DateTime('+3 days')) {

reference/forms/types/collection.rst

@@ -15,9 +15,9 @@ you can list the most popular on top, like Bork Bork and Pirate::
             'English' => 'en',
             'Spanish' => 'es',
             'Bork'   => 'muppets',
-            'Pirate' => 'arr'
+            'Pirate' => 'arr',
         ),
-        'preferred_choices' => array('muppets', 'arr')
+        'preferred_choices' => array('muppets', 'arr'),
     ));
 
 This options can also be a callback function to give you more flexibility. This might
@@ -31,7 +31,7 @@ be especially useful if your values are objects::
             'now' => new \DateTime('now'),
             'tomorrow' => new \DateTime('+1 day'),
             '1 week' => new \DateTime('+1 week'),
-            '1 month' => new \DateTime('+1 month')
+            '1 month' => new \DateTime('+1 month'),
         ),
         'preferred_choices' => function ($val, $key) {
             // prefer options within 3 days

reference/forms/types/date.rst

@@ -65,7 +65,7 @@ a routing ``{wildcard}`` to only match some regular expression:
         $collection->add('blog_list', new Route('/blog/{page}', array(
             '_controller' => 'App\Controller\BlogController::list',
         ), array(
-            'page' => '\d+'
+            'page' => '\d+',
         )));
 
         // ...

reference/forms/types/options/group_by.rst.inc

@@ -209,11 +209,11 @@ pattern so that it is only accessible by requests from the local server itself:
                 array(
                     'path' => '^/internal',
                     'role' => 'IS_AUTHENTICATED_ANONYMOUSLY',
-                    'ips' => '127.0.0.1, ::1'
+                    'ips' => '127.0.0.1, ::1',
                 ),
                 array(
                     'path' => '^/internal',
-                    'role' => 'ROLE_NO_ACCESS'
+                    'role' => 'ROLE_NO_ACCESS',
                 ),
             ),
         ));

reference/forms/types/options/preferred_choices.rst.inc

@@ -269,7 +269,7 @@ After this, you have protected your login form against CSRF attacks.
                         'form_login' => array(
                             // ...
                             'csrf_parameter' => '_csrf_security_token',
-                            'csrf_token_id'     => 'a_private_string'
+                            'csrf_token_id'  => 'a_private_string',
                         ),
                     ),
                 ),

routing/requirements.rst

@@ -369,14 +369,14 @@ so you only need the new interface::
         {
             return serialize(array(
                 // ...
-                $this->isActive
+                $this->isActive,
             ));
         }
         public function unserialize($serialized)
         {
             list (
                 // ...
-                $this->isActive
+                $this->isActive,
             ) = unserialize($serialized);
         }
     }

security/access_control.rst

@@ -158,6 +158,12 @@ Great! Next, add the logic to ``login()`` that displays the login form::
         ));
     }
 
+.. note::
+
+    If you get an error that the ``$authUtils`` argument is missing, it's
+    probably because you need to activate this new feature in Symfony 3.4. See
+    this :ref:`controller service argument note <controller-service-arguments-tag>`.
+
 Don't let this controller confuse you. As you'll see in a moment, when the
 user submits the form, the security system automatically handles the form
 submission for you. If the user submits an invalid username or password,

security/csrf.rst

@@ -417,8 +417,9 @@ Each authenticator needs the following methods:
 
 The picture below shows how Symfony calls Guard Authenticator methods:
 
-.. image:: /_images/security/authentication-guard-methods.png
-   :align: center
+.. raw:: html
+
+    <object data="../_images/security/authentication-guard-methods.svg" type="image/svg+xml"></object>
 
 .. _guard-customize-error:
 

security/entity_provider.rst

@@ -198,32 +198,32 @@ The :doc:`/session/locale_sticky_session` article does not update the locale
 when you impersonate a user. If you *do* want to be sure to update the locale when
 you switch users, add an event subscriber on this event::
 
-        // src/EventListener/SwitchUserListener.php
-        namespace App\EventListener;
+    // src/EventListener/SwitchUserListener.php
+    namespace App\EventListener;
 
-        use Symfony\Component\Security\Http\Event\SwitchUserEvent;
-        use Symfony\Component\EventDispatcher\EventSubscriberInterface;
-        use Symfony\Component\Security\Http\SecurityEvents;
+    use Symfony\Component\Security\Http\Event\SwitchUserEvent;
+    use Symfony\Component\EventDispatcher\EventSubscriberInterface;
+    use Symfony\Component\Security\Http\SecurityEvents;
 
-        class SwitchUserSubscriber implements EventSubscriberInterface
+    class SwitchUserSubscriber implements EventSubscriberInterface
+    {
+        public function onSwitchUser(SwitchUserEvent $event)
         {
-            public function onSwitchUser(SwitchUserEvent $event)
-            {
-                $event->getRequest()->getSession()->set(
-                    '_locale',
-                    // assuming your User has some getLocale() method
-                    $event->getTargetUser()->getLocale()
-                );
-            }
+            $event->getRequest()->getSession()->set(
+                '_locale',
+                // assuming your User has some getLocale() method
+                $event->getTargetUser()->getLocale()
+            );
+        }
 
-            public static function getSubscribedEvents()
-            {
-                return array(
-                    // constant for security.switch_user
-                    SecurityEvents::SWITCH_USER => 'onSwitchUser',
-                );
-            }
+        public static function getSubscribedEvents()
+        {
+            return array(
+                // constant for security.switch_user
+                SecurityEvents::SWITCH_USER => 'onSwitchUser',
+            );
         }
+    }
 
 That's it! If you're using the :ref:`default services.yaml configuration <service-container-services-load-example>`,
 Symfony will automatically discover your service and call ``onSwitchUser`` whenever

security/form_login_setup.rst

@@ -96,7 +96,7 @@ named encoders:
             'encoders' => array(
                 'harsh' => array(
                     'algorithm' => 'bcrypt',
-                    'cost'      => '15'
+                    'cost'      => '15',
                 ),
             ),
         ));
@@ -174,7 +174,7 @@ you must register a service for it in order to use it as a named encoder:
             // ...
             'encoders' => array(
                 'app_encoder' => array(
-                    'id' => MyCustomPasswordEncoder::class
+                    'id' => MyCustomPasswordEncoder::class,
                 ),
             ),
         ));