Skip to content

Commit 9a3cfde

Browse files
committed
Merge branch '4.4' into 5.3
* 4.4: Local development Docker improvements Contributing guidelines: make version reference older than current maintained version Deleting npm from yarn code block
2 parents 9601d02 + ad9900c commit 9a3cfde

File tree

4 files changed

+16
-7
lines changed

4 files changed

+16
-7
lines changed

.dockerignore

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
/.git
2+
/_build/doctrees
3+
/_build/spelling
4+
/_build/html
5+
/_build/logs.txt
6+
/_build/vendor
7+
/_build/output
8+
*.pyc

Dockerfile

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,20 @@
1-
FROM python:2-stretch as builder
1+
FROM python:2-alpine as builder
22

33
WORKDIR /www
44

55
COPY ./_build/.requirements.txt _build/
66

7-
RUN pip install pip==9.0.1 wheel==0.29.0 \
7+
RUN apk add \
8+
git \
9+
make
10+
11+
RUN pip install pip==9.0.1 wheel==0.29.0 \
812
&& pip install -r _build/.requirements.txt
913

1014
COPY . /www
1115

1216
RUN make -C _build html
1317

14-
FROM nginx:latest
18+
FROM nginx:alpine
1519

1620
COPY --from=builder /www/_build/html /usr/share/nginx/html

contributing/documentation/overview.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ branch of the ``upstream`` remote, which is the original Symfony Docs repository
121121
Fixes should always be based on the **oldest maintained branch** which contains
122122
the error. Nowadays this is the ``4.4`` branch. If you are instead documenting a
123123
new feature, switch to the first Symfony version that included it, e.g.
124-
``upstream/3.1``.
124+
``upstream/5.4``.
125125

126126
**Step 5.** Now make your changes in the documentation. Add, tweak, reword and
127127
even remove any content and do your best to comply with the

frontend/encore/simple-example.rst

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,6 @@ To build the assets, run the following if you use the Yarn package manager:
6868
# on deploy, create a production build
6969
$ yarn encore production
7070
71-
# if you use the npm package manager
72-
$ npm install react react-dom prop-types --save
73-
7471
If you use the npm package manager, run the following commands instead:
7572

7673
.. code-block:: terminal

0 commit comments

Comments
 (0)