minor #13197 Maybe the login path should be excluded (danielsan80)

javiereguiluz · javiereguiluz · commit 93274ab09cd2 · 2020-02-22T11:17:16.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- Maybe the login path should be excluded Maybe the login path should be excluded from the target pathes saved. Commits ------- 292b5e7 Maybe the login path should be excluded
diff --git a/security/form_login_setup.rst b/security/form_login_setup.rst
@@ -453,7 +453,11 @@ whenever the user browses a page::
         public function onKernelRequest(RequestEvent $event): void
         {
             $request = $event->getRequest();
-            if (!$event->isMasterRequest() || $request->isXmlHttpRequest()) {
+            if (
+                !$event->isMasterRequest()
+                || $request->isXmlHttpRequest()
+                || 'app_login' === $request->attributes->get('_route')
+            ) {
                 return;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -453,7 +453,11 @@ whenever the user browses a page::`
`453`	`453`	`public function onKernelRequest(RequestEvent $event): void`
`454`	`454`	`{`
`455`	`455`	`$request = $event->getRequest();`
`456`		`- if (!$event->isMasterRequest() \|\| $request->isXmlHttpRequest()) {`
	`456`	`+ if (`
	`457`	`+ !$event->isMasterRequest()`
	`458`	`+ \|\| $request->isXmlHttpRequest()`
	`459`	`+ \|\| 'app_login' === $request->attributes->get('_route')`
	`460`	`+ ) {`
`457`	`461`	`return;`
`458`	`462`	`}`
`459`	`463`