Skip to content

Commit 900b38f

Browse files
committed
minor #17445 [Console] Fix incorrect example for CommandCompletionTester (weitzman)
This PR was merged into the 5.4 branch. Discussion ---------- [Console] Fix incorrect example for `CommandCompletionTester` <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 9f12399 Fix incorrect example for CommandCompletionTester
2 parents 42640c7 + 9f12399 commit 900b38f

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

console/input.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,8 +397,10 @@ to help you unit test the completion logic::
397397
$this->assertSame(['Fabien', 'Fabrice', 'Wouter'], $suggestions);
398398

399399
// complete the input with "Fa" as input
400+
// note that the list does not reduce because the completion tester doesn't run any shell,
401+
// it only tests the PHP part of the completion logic, so it should always include all values
400402
$suggestions = $tester->complete(['Fa']);
401-
$this->assertSame(['Fabien', 'Fabrice'], $suggestions);
403+
$this->assertSame(['Fabien', 'Fabrice', 'Wouter'], $suggestions);
402404
}
403405
}
404406

0 commit comments

Comments
 (0)