Skip to content

Commit 6e1317f

Browse files
committed
minor #16914 Add more clarity about things that cannot be done while working on a bug fix patch (fabpot)
This PR was merged into the 4.4 branch. Discussion ---------- Add more clarity about things that cannot be done while working on a bug fix patch Commits ------- b03c44c Add more clarity about things that cannot be done while working on a bug fix patch
2 parents 27fc3a1 + b03c44c commit 6e1317f

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

contributing/code/maintenance.rst

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ acceptable changes.
1111
* New unit tests cover the bug fix;
1212
* The current buggy behavior is not widely used as a "feature".
1313

14-
While working on a bug fix, don't refactor the code or introduce new classes.
15-
1614
.. note::
1715

1816
When documentation (or PHPDoc) is not in sync with the code, code behavior
@@ -46,7 +44,8 @@ a case by case basis:
4644
* **Tests**: Tests that increase the code coverage can be added.
4745

4846
The following changes are **generally not accepted** in a patch version, except
49-
on a case by case basis:
47+
on a case by case basis (mostly when this is related to fixing a security
48+
issue):
5049

5150
* **Performance improvement**: Performance improvement should only be accepted
5251
if the changes are local (located in one class) and only for algorithmic
@@ -58,6 +57,16 @@ on a case by case basis:
5857
existing code base, if they are not too invasive, and if merging them into
5958
higher branches would not lead to complex branch merging.
6059

60+
* **Adding new classes or non private methods**: While working on a bug fix,
61+
never introduce new classes or public/protected methods (or global
62+
functions).
63+
64+
* **Adding configuration options**: Introducing new configuration options must
65+
never allowed.
66+
67+
* **Adding new deprecations**: After a version reaches stability, new
68+
deprecations cannot be added anymore.
69+
6170
Anything not explicitly listed above should be done on the next minor or major
6271
version instead. For instance, the following changes are never accepted in a
6372
patch version:

0 commit comments

Comments
 (0)