Skip to content

Commit 63edb18

Browse files
elghailanijaviereguiluz
authored andcommitted
Update best_practices.rst
Improve Environment Variables, Secrets & Functional Test wording
1 parent 2b48345 commit 63edb18

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

best_practices.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ Configuration
8181
Use Environment Variables for Infrastructure Configuration
8282
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
8383

84-
These are the options that change from one machine to another (e.g. from your
84+
These are the options that their values changes from one machine to another (e.g. from your
8585
development machine to the production server) but which don't change the
8686
application behavior.
8787

@@ -92,7 +92,7 @@ Use Secret for Sensitive Information
9292
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
9393

9494
When your application has sensitive configuration - like an API key - you should
95-
store those securely via :doc:`secrets </configuration/secrets>`.
95+
store those securely via :doc:`Symfony’s secrets management system </configuration/secrets>`.
9696

9797
Use Parameters for Application Configuration
9898
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -430,19 +430,19 @@ functional test that checks that all application URLs load successfully::
430430
}
431431

432432
Add this test while creating your application because it requires little effort
433-
and checks that none of your pages returns an error. Later you'll add more
433+
and checks that none of your pages returns an error. Later, you'll add more
434434
specific tests for each page.
435435

436436
Hardcode URLs in a Functional Test
437437
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
438438

439-
In Symfony applications it's recommended to :ref:`generate URLs <routing-generating-urls>`
439+
In Symfony applications, it's recommended to :ref:`generate URLs <routing-generating-urls>`
440440
using routes to automatically update all links when a URL changes. However, if a
441441
public URL changes, users won't be able to browse it unless you set up a
442442
redirection to the new URL.
443443

444444
That's why it's recommended to use raw URLs in tests instead of generating them
445-
from routes. Whenever a route changes, tests will break and you'll know that
445+
from routes. Whenever a route changes, tests will fail and you'll know that
446446
you must set up a redirection.
447447

448448
.. _`Symfony Demo`: https://github.com/symfony/demo

0 commit comments

Comments
 (0)