Skip to content

Commit 5ca91b6

Browse files
committed
minor #17452 Fix confusing example of type-hinting the Request object (theofidry)
This PR was merged into the 4.4 branch. Discussion ---------- Fix confusing example of type-hinting the Request object As far as I can see, this piece of doc is incorrect as `$firstName` and `$lastName` wouldn't be injected properly there and the piece of doc in question is not about those two parameters either. As such I propose to remove them from the example to prevent any confusion. Commits ------- 4351c89 Fix bad copy/paste
2 parents 7ff22c8 + 4351c89 commit 5ca91b6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

controller.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ object. To access it in your controller, add it as an argument and
381381
use Symfony\Component\HttpFoundation\Response;
382382
// ...
383383

384-
public function index(Request $request, string $firstName, string $lastName): Response
384+
public function index(Request $request): Response
385385
{
386386
$page = $request->query->get('page', 1);
387387

0 commit comments

Comments
 (0)