Skip to content

Commit 4f0cd5a

Browse files
committed
minor #13001 composer issue for prefer-lowest has been fixed (dbu)
This PR was submitted for the 4.4 branch but it was merged into the 4.3 branch instead (closes #13001). Discussion ---------- composer issue for prefer-lowest has been fixed The issue composer/composer#5355 has been fixed in composer 1.8 and therefore the workaround is no longer needed. I have tried on a couple of projects that i don't get errors on travis-ci when removing the instruction. Once this is in 4.4, it should also be merged to the newer versions. Commits ------- 000ebb5 composer issue for prefer-lowest has been fixed
2 parents de1e1e5 + 000ebb5 commit 4f0cd5a

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

bundles/best_practices.rst

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,8 +227,6 @@ of Symfony and the latest beta release:
227227
- if ! [ -v "$DEPENDENCIES" ]; then composer require --no-update ${DEPENDENCIES}; fi;
228228
229229
install:
230-
# To be removed when this issue will be resolved: https://github.com/composer/composer/issues/5355
231-
- if [[ "$COMPOSER_FLAGS" == *"--prefer-lowest"* ]]; then composer update --prefer-dist --no-interaction --prefer-stable --quiet; fi
232230
- composer update ${COMPOSER_FLAGS} --prefer-dist --no-interaction
233231
- ./vendor/bin/simple-phpunit install
234232

0 commit comments

Comments
 (0)