Skip to content

Commit 4a3fbed

Browse files
committed
Fix comments
1 parent a5f6d24 commit 4a3fbed

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

contributing/code/bc.rst

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -212,28 +212,28 @@ Remove public method No
212212
Change name No
213213
Reduce visibility No
214214
Move to parent class Yes
215-
Add argument without a default value No [7]_
216-
Add argument with a default value No [7]_
215+
Add argument without a default value No
216+
Add argument with a default value No [7]_ [8]_
217217
Remove argument Yes [3]_
218-
Add default value to an argument No [7]_
219-
Remove default value of an argument No [7]_
220-
Add type hint to an argument No [7]_
221-
Remove type hint of an argument No [7]_
222-
Change argument type No [7]_
223-
Change return type No [7]_
218+
Add default value to an argument No [7]_ [8]_
219+
Remove default value of an argument No
220+
Add type hint to an argument No
221+
Remove type hint of an argument No [7]_ [8]_
222+
Change argument type No
223+
Change return type No
224224
**Protected Methods**
225225
Add protected method Yes
226226
Remove protected method No [7]_
227227
Change name No [7]_
228228
Reduce visibility No [7]_
229229
Move to parent class Yes
230230
Add argument without a default value No [7]_
231-
Add argument with a default value No [7]_
231+
Add argument with a default value No [7]_ [8]_
232232
Remove argument Yes [3]_
233-
Add default value to an argument No [7]_
233+
Add default value to an argument No [7]_ [8]_
234234
Remove default value of an argument No [7]_
235235
Add type hint to an argument No [7]_
236-
Remove type hint of an argument No [7]_
236+
Remove type hint of an argument No [7]_ [8]_
237237
Change argument type No [7]_
238238
Change return type No [7]_
239239
**Private Methods**
@@ -250,7 +250,7 @@ Remove type hint of an argument Yes
250250
Change argument type Yes
251251
Change return type Yes
252252
**Static Methods**
253-
Turn non static into static No [7]_
253+
Turn non static into static No [7]_ [8]_
254254
Turn static into non static No
255255
**Constants**
256256
Add constant Yes
@@ -279,7 +279,9 @@ Change value of a constant Yes [1]_ [5]_
279279
280280
.. [6] Allowed using the ``@final`` annotation.
281281
282-
.. [7] Allowed if the class/method is final.
282+
.. [7] Allowed if the class is final.
283+
284+
.. [8] Allowed if the method is final.
283285
284286
.. _Semantic Versioning: http://semver.org/
285287
.. _scalar type: http://php.net/manual/en/function.is-scalar.php

0 commit comments

Comments
 (0)