Skip to content

Commit 45714a4

Browse files
committed
minor #5312 Some fixes for bundle best practices (WouterJ)
This PR was merged into the 2.3 branch. Discussion ---------- Some fixes for bundle best practices | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- c2f39b4 Some fixes for bundle best practices
2 parents e211600 + c2f39b4 commit 45714a4

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

cookbook/bundles/best_practices.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ class name is ``Acme\BlogBundle\Controller\ContentController``.
146146
All classes and files must follow the :doc:`Symfony coding standards </contributing/code/standards>`.
147147

148148
Some classes should be seen as facades and should be as short as possible, like
149-
Commands, Helpers, Listeners, and Controllers.
149+
Commands, Helpers, Listeners and Controllers.
150150

151151
Classes that connect to the event dispatcher should be suffixed with
152152
``Listener``.
@@ -159,7 +159,7 @@ Vendors
159159
A bundle must not embed third-party PHP libraries. It should rely on the
160160
standard Symfony autoloading instead.
161161

162-
A bundle should not embed third-party libraries written in JavaScript, CSS, or
162+
A bundle should not embed third-party libraries written in JavaScript, CSS or
163163
any other language.
164164

165165
Tests
@@ -175,6 +175,7 @@ the ``Tests/`` directory. Tests should follow the following principles:
175175
* The tests should cover at least 95% of the code base.
176176

177177
.. note::
178+
178179
A test suite must not contain ``AllTests.php`` scripts, but must rely on the
179180
existence of a ``phpunit.xml.dist`` file.
180181

0 commit comments

Comments
 (0)