Skip to content

Commit 454cb0d

Browse files
committed
Merge branch '3.4' into 4.4
* 3.4: Change branch "master" to "5.x" Change "-t" to "--track" to be more explicit Fix typo
2 parents 7f41dfb + 76d6493 commit 454cb0d

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

contributing/code/pull_requests.rst

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ work:
129129
</contributing/code/maintenance>` (you may have to choose a higher branch if
130130
the feature you are fixing was introduced in a later version);
131131

132-
* ``master``, if you are adding a new feature.
132+
* ``5.x``, if you are adding a new feature.
133133

134134
The only exception is when a new :doc:`major Symfony version </contributing/community/releases>`
135135
(4.0, 5.0, etc.) comes out every two years. Because of the
@@ -142,7 +142,7 @@ work:
142142
All bug fixes merged into maintenance branches are also merged into more
143143
recent branches on a regular basis. For instance, if you submit a PR
144144
for the ``3.4`` branch, the PR will also be applied by the core team on
145-
the ``master`` branch.
145+
the ``5.x`` branch.
146146

147147
Create a Topic Branch
148148
~~~~~~~~~~~~~~~~~~~~~
@@ -152,14 +152,14 @@ topic branch:
152152

153153
.. code-block:: terminal
154154
155-
$ git checkout -b BRANCH_NAME master
155+
$ git checkout -b BRANCH_NAME 5.x
156156
157157
Or, if you want to provide a bug fix for the ``3.4`` branch, first track the remote
158158
``3.4`` branch locally:
159159

160160
.. code-block:: terminal
161161
162-
$ git checkout -t origin/3.4
162+
$ git checkout --track origin/3.4
163163
164164
Then create a new branch off the ``3.4`` branch to work on the bug fix:
165165

@@ -277,15 +277,15 @@ while to finish your changes):
277277

278278
.. code-block:: terminal
279279
280-
$ git checkout master
280+
$ git checkout 5.x
281281
$ git fetch upstream
282-
$ git merge upstream/master
282+
$ git merge upstream/5.x
283283
$ git checkout BRANCH_NAME
284-
$ git rebase master
284+
$ git rebase 5.x
285285
286286
.. tip::
287287

288-
Replace ``master`` with the branch you selected previously (e.g. ``3.4``)
288+
Replace ``5.x`` with the branch you selected previously (e.g. ``3.4``)
289289
if you are working on a bug fix.
290290

291291
When doing the ``rebase`` command, you might have to fix merge conflicts.
@@ -402,12 +402,12 @@ Rework your Pull Request
402402
~~~~~~~~~~~~~~~~~~~~~~~~
403403

404404
Based on the feedback on the pull request, you might need to rework your
405-
PR. Before re-submitting the PR, rebase with ``upstream/master`` or
405+
PR. Before re-submitting the PR, rebase with ``upstream/5.x`` or
406406
``upstream/3.4``, don't merge; and force the push to the origin:
407407

408408
.. code-block:: terminal
409409
410-
$ git rebase -f upstream/master
410+
$ git rebase -f upstream/5.x
411411
$ git push --force origin BRANCH_NAME
412412
413413
.. note::

testing.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -840,7 +840,7 @@ their type::
840840
$form['photo']->upload('/path/to/lucas.jpg');
841841

842842
// In the case of a multiple file upload
843-
$form['my_form[field][O]']->upload('/path/to/lucas.jpg');
843+
$form['my_form[field][0]']->upload('/path/to/lucas.jpg');
844844
$form['my_form[field][1]']->upload('/path/to/lisa.jpg');
845845

846846
.. tip::

0 commit comments

Comments
 (0)