Skip to content

Commit 2c7db6b

Browse files
committed
minor #14649 Prefer sass over node-sass (weaverryan)
This PR was submitted for the 5.2 branch but it was merged into the 4.4 branch instead. Discussion ---------- Prefer sass over node-sass Hi! `node-sass` is deprecated in favor of `sass` - https://sass-lang.com/blog/libsass-is-deprecated. Encore works exactly the same with both, and `sass` doesn't require an annoying compile step that sometimes fails anyways. And also, here is the PR that will change which library is recommended: symfony/webpack-encore#870 I will merge and tag that shortly. Commits ------- 41418b7 Prefer sass over node-sass
2 parents 7dbd4de + 41418b7 commit 2c7db6b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

frontend/encore/simple-example.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -311,15 +311,15 @@ Encore. When you do, you'll see an error!
311311

312312
.. code-block:: terminal
313313
314-
> Error: Install sass-loader & node-sass to use enableSassLoader()
315-
> yarn add sass-loader@^8.0.0 node-sass --dev
314+
> Error: Install sass-loader & sass to use enableSassLoader()
315+
> yarn add sass-loader@^10.0.0 sass --dev
316316
317317
Encore supports many features. But, instead of forcing all of them on you, when
318318
you need a feature, Encore will tell you what you need to install. Run:
319319

320320
.. code-block:: terminal
321321
322-
$ yarn add sass-loader@^8.0.0 node-sass --dev
322+
$ yarn add sass-loader@^10.0.0 sass --dev
323323
$ yarn encore dev --watch
324324
325325
Your app now supports Sass. Encore also supports LESS and Stylus. See

0 commit comments

Comments
 (0)