Merge branch '4.1'

* 4.1:
  Fixed some wrong links to external API classes/methods
  Improve functional test workflow example
  Added documentation about authentication for multiple firewalls under the same firewall context
  Fix missing use of IssueSelectorType
  Fixed URLs to APIs outside of the Symfony project

Author: javiereguiluz

components/cache/cache_items.rst

@@ -33,7 +33,7 @@ argument is the key of the item::
     // $cache pool object was created before
     $productsCount = $cache->getItem('stats.products_count');
 
-Then, use the :method:`Psr\\Cache\\CacheItemInterface::set` method to set
+Then, use the ``Psr\\Cache\\CacheItemInterface::set`` method to set
 the data stored in the cache item::
 
     // storing a simple integer

components/cache/cache_pools.rst

@@ -69,7 +69,7 @@ Saving Cache Items
 ------------------
 
 The most common method to save cache items is
-:method:`Psr\\Cache\\CacheItemPoolInterface::save`, which stores the
+``Psr\\Cache\\CacheItemPoolInterface::save``, which stores the
 item in the cache immediately (it returns ``true`` if the item was saved or
 ``false`` if some error occurred)::
 
@@ -80,9 +80,9 @@ item in the cache immediately (it returns ``true`` if the item was saved or
 
 Sometimes you may prefer to not save the objects immediately in order to
 increase the application performance. In those cases, use the
-:method:`Psr\\Cache\\CacheItemPoolInterface::saveDeferred` method to mark cache
+``Psr\\Cache\\CacheItemPoolInterface::saveDeferred`` method to mark cache
 items as "ready to be persisted" and then call to
-:method:`Psr\\Cache\\CacheItemPoolInterface::commit` method when you are ready
+``Psr\\Cache\\CacheItemPoolInterface::commit`` method when you are ready
 to persist them all::
 
     // ...
@@ -103,22 +103,22 @@ Removing Cache Items
 --------------------
 
 Cache Pools include methods to delete a cache item, some of them or all of them.
-The most common is :method:`Psr\\Cache\\CacheItemPoolInterface::deleteItem`,
+The most common is ``Psr\\Cache\\CacheItemPoolInterface::deleteItem``,
 which deletes the cache item identified by the given key (it returns ``true``
 when the item is successfully deleted or doesn't exist and ``false`` otherwise)::
 
     // ...
     $isDeleted = $cache->deleteItem('user_'.$userId);
 
-Use the :method:`Psr\\Cache\\CacheItemPoolInterface::deleteItems` method to
+Use the ``Psr\\Cache\\CacheItemPoolInterface::deleteItems`` method to
 delete several cache items simultaneously (it returns ``true`` only if all the
 items have been deleted, even when any or some of them don't exist)::
 
     // ...
     $areDeleted = $cache->deleteItems(array('category1', 'category2'));
 
 Finally, to remove all the cache items stored in the pool, use the
-:method:`Psr\\Cache\\CacheItemPoolInterface::clear` method (which returns ``true``
+``Psr\\Cache\\CacheItemPoolInterface::clear`` method (which returns ``true``
 when all items are successfully deleted)::
 
     // ...
@@ -162,7 +162,7 @@ Pruning Cache Items
 Some cache pools do not include an automated mechanism for pruning expired cache items.
 For example, the :ref:`FilesystemAdaper <component-cache-filesystem-adapter>` cache
 does not remove expired cache items *until an item is explicitly requested and determined to
-be expired*, for example, via a call to :method:`Psr\\Cache\\CacheItemPoolInterface::getItem`.
+be expired*, for example, via a call to ``Psr\\Cache\\CacheItemPoolInterface::getItem``.
 Under certain workloads, this can cause stale cache entries to persist well past their
 expiration, resulting in a sizable consumption of wasted disk or memory space from excess,
 expired cache items.

components/psr7.rst

@@ -36,8 +36,8 @@ that builds objects implementing PSR-7 interfaces from HttpFoundation objects.
 It also provide a default implementation using Zend Diactoros internally.
 
 The following code snippet explain how to convert a :class:`Symfony\\Component\\HttpFoundation\\Request`
-to a Zend Diactoros :class:`Zend\\Diactoros\\ServerRequest` implementing the
-:class:`Psr\\Http\\Message\\ServerRequestInterface` interface::
+to a ``Zend\\Diactoros\\ServerRequest`` class implementing the
+``Psr\\Http\\Message\\ServerRequestInterface`` interface::
 
     use Symfony\Bridge\PsrHttpMessage\Factory\DiactorosFactory;
     use Symfony\Component\HttpFoundation\Request;
@@ -48,9 +48,9 @@ to a Zend Diactoros :class:`Zend\\Diactoros\\ServerRequest` implementing the
     $psr7Factory = new DiactorosFactory();
     $psrRequest = $psr7Factory->createRequest($symfonyRequest);
 
-And now from a :class:`Symfony\\Component\\HttpFoundation\\Response` to a Zend
-Diactoros :class:`Zend\\Diactoros\\Response` implementing the :class:`Psr\\Http\\Message\\ResponseInterface`
-interface::
+And now from a :class:`Symfony\\Component\\HttpFoundation\\Response` to a
+``Zend\\Diactoros\\Response`` class implementing the
+``Psr\\Http\\Message\\ResponseInterface`` interface::
 
     use Symfony\Bridge\PsrHttpMessage\Factory\DiactorosFactory;
     use Symfony\Component\HttpFoundation\Response;
@@ -68,8 +68,8 @@ On the other hand, the bridge provide a factory interface called
 that builds HttpFoundation objects from objects implementing PSR-7 interfaces.
 
 The next snippet explain how to convert an object implementing the
-:class:`Psr\\Http\\Message\\ServerRequestInterface`
-interface to a :class:`Symfony\\Component\\HttpFoundation\\Request` instance::
+``Psr\\Http\\Message\\ServerRequestInterface`` interface to a
+:class:`Symfony\\Component\\HttpFoundation\\Request` instance::
 
     use Symfony\Bridge\PsrHttpMessage\Factory\HttpFoundationFactory;
 
@@ -78,7 +78,7 @@ interface to a :class:`Symfony\\Component\\HttpFoundation\\Request` instance::
     $httpFoundationFactory = new HttpFoundationFactory();
     $symfonyRequest = $httpFoundationFactory->createRequest($psrRequest);
 
-From an object implementing the :class:`Psr\\Http\\Message\\ResponseInterface`
+From an object implementing the ``Psr\\Http\\Message\\ResponseInterface``
 to a :class:`Symfony\\Component\\HttpFoundation\\Response` instance::
 
     use Symfony\Bridge\PsrHttpMessage\Factory\HttpFoundationFactory;

reference/configuration/framework.rst

@@ -1864,7 +1864,7 @@ The name of the adapter to use. You could also use your own implementation.
 
 .. note::
 
-    Your service MUST implement the :class:`Psr\\Cache\\CacheItemPoolInterface` interface.
+    Your service MUST implement the ``Psr\\Cache\\CacheItemPoolInterface`` interface.
 
 public
 """"""

testing.rst

@@ -120,7 +120,6 @@ application (from the routing to the views). They are no different from unit
 tests as far as PHPUnit is concerned, but they have a very specific workflow:
 
 * Make a request;
-* Test the response;
 * Click on a link or submit a form;
 * Test the response;
 * Rinse and repeat.

testing/http_authentication.rst

@@ -113,10 +113,12 @@ needs::
         {
             $session = $this->client->getContainer()->get('session');
 
-            // the firewall context defaults to the firewall name
+            $firewallName = 'secure_area';
+            // if you don't define multiple connected firewalls, the context defaults to the firewall name
+            // See https://symfony.com/doc/current/reference/configuration/security.html#firewall-context
             $firewallContext = 'secured_area';
 
-            $token = new UsernamePasswordToken('admin', null, $firewallContext, array('ROLE_ADMIN'));
+            $token = new UsernamePasswordToken('admin', null, $firewallName, array('ROLE_ADMIN'));
             $session->set('_security_'.$firewallContext, serialize($token));
             $session->save();