Merge branch '4.3' into 4.4

* 4.3:
  Tweaks #11274
  initial DOCtor-RST setup.
  [#12191] Fixed another wrong namespace
  Fixed namespace in example
  fix a little code example issue
  Remove unused link
  Adding missing semi colons
  Fix Description of PHPUnitBridge
  Fix variable name

Author: OskarStark

.doctor-rst.yaml

@@ -0,0 +1,82 @@
+rules:
+    no_inheritdoc: ~
+    avoid_repetetive_words: ~
+    blank_line_after_directive: ~
+    short_array_syntax: ~
+    no_app_console: ~
+    typo: ~
+    replacement: ~
+    composer_dev_option_not_at_the_end: ~
+    yarn_dev_option_at_the_end: ~
+    versionadded_directive_should_have_version: ~
+    deprecated_directive_should_have_version: ~
+    no_composer_req: ~
+    no_php_open_tag_in_code_block_php_directive: ~
+    no_blank_line_after_filepath_in_php_code_block: ~
+    no_blank_line_after_filepath_in_yaml_code_block: ~
+    no_blank_line_after_filepath_in_xml_code_block: ~
+    no_blank_line_after_filepath_in_twig_code_block: ~
+    php_prefix_before_bin_console: ~
+    use_deprecated_directive_instead_of_versionadded: ~
+    no_space_before_self_xml_closing_tag: ~
+    no_explicit_use_of_code_block_php: ~
+    ensure_order_of_code_blocks_in_configuration_block: ~
+    american_english: ~
+    valid_use_statements: ~
+    lowercase_as_in_use_statements: ~
+    ordered_use_statements: ~
+    no_namespace_after_use_statements: ~
+    correct_code_block_directive_based_on_the_content: ~
+    max_blank_lines:
+        max: 2
+    replace_code_block_types: ~
+    use_https_xsd_urls: ~
+    blank_line_before_directive: ~
+    extension_xlf_instead_of_xliff: ~
+    valid_inline_highlighted_namespaces: ~
+    indention: ~
+    unused_links: ~
+    yaml_instead_of_yml_suffix: ~
+    extend_abstract_controller: ~
+#    no_app_bundle: ~
+
+    #   4.x
+    versionadded_directive_major_version:
+        major_version: 4
+
+    versionadded_directive_min_version:
+        min_version: '4.0'
+
+    deprecated_directive_major_version:
+        major_version: 4
+
+    deprecated_directive_min_version:
+        min_version: '4.0'
+
+# do not report as violation
+whitelist:
+    regex:
+        - '/FOSUserBundle(.*)\.yml/'
+        - '/``.yml``/'
+        - '/(.*)\.orm\.yml/' # currently DoctrineBundle only supports .yml
+    lines:
+        - 'in config files, so the old ``app/config/config_dev.yml`` goes to'
+        - '#. The most important config file is ``app/config/services.yml``, which now is'
+        - 'code in production without a proxy, it becomes trivially easy to abuse your'
+        - '.. _`EasyDeployBundle`: https://github.com/EasyCorp/easy-deploy-bundle'
+        - 'The bin/console Command'
+        - '# username is your full Gmail or Google Apps email address'
+        - '.. _`LDAP injection`: http://projects.webappsec.org/w/page/13246947/LDAP%20Injection'
+        - '.. versionadded:: 0.21.0' # Encore
+        - '.. versionadded:: 2.4.0' # SwiftMailer
+        - '.. versionadded:: 1.26' # Twig
+        - '.. versionadded:: 1.30' # Twig
+        - '.. versionadded:: 1.2' # MakerBundle
+        - '.. versionadded:: 1.11' # MakerBundle
+        - '.. versionadded:: 1.3' # MakerBundle
+        - '.. versionadded:: 1.8' # MakerBundle
+        - '0 => 123' # assertion for var_dumper - components/var_dumper.rst
+        - '1 => "foo"' # assertion for var_dumper - components/var_dumper.rst
+        - '$var .= "Because of this `\xE9` octet (\\xE9),\n";'
+        - "`Deploying Symfony 4 Apps on Heroku`_."
+        - ".. _`Deploying Symfony 4 Apps on Heroku`: https://devcenter.heroku.com/articles/deploying-symfony4"

.github/workflows/lint.yaml

@@ -0,0 +1,12 @@
+on: push
+name: Lint
+jobs:
+    doctor-rst:
+        name: DOCtor-RST
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@master
+            - name: DOCtor-RST
+              uses: docker://oskarstark/doctor-rst
+              with:
+                  args: --short

cache.rst

@@ -449,13 +449,13 @@ the same key could be invalidate with one function call::
     use Symfony\Contracts\Cache\ItemInterface;
 
     $value0 = $pool->get('item_0', function (ItemInterface $item) {
-        $item->tag(['foo', 'bar'])
+        $item->tag(['foo', 'bar']);
 
         return 'debug';
     });
 
     $value1 = $pool->get('item_1', function (ItemInterface $item) {
-        $item->tag('foo')
+        $item->tag('foo');
 
         return 'debug';
     });

components/phpunit_bridge.rst

@@ -882,7 +882,7 @@ not find the SUT:
         </listener>
     </listeners>
 
-.. _PHPUnit: https://phpunit.de
+.. _`PHPUnit`: https://phpunit.de
 .. _`PHPUnit event listener`: https://phpunit.de/manual/current/en/extending-phpunit.html#extending-phpunit.PHPUnit_Framework_TestListener
 .. _`PHPUnit's assertStringMatchesFormat()`: https://phpunit.de/manual/current/en/appendixes.assertions.html#appendixes.assertions.assertStringMatchesFormat
 .. _`PHP error handler`: https://php.net/manual/en/book.errorfunc.php

components/serializer.rst

@@ -655,7 +655,7 @@ When serializing, you can set a callback to format a specific object property::
     $encoder = new JsonEncoder();
 
     // all callback parameters are optional (you can omit the ones you don't use)
-    $callback = function ($innerObject, $outerObject, string $attributeName, string $format = null, array $context = []) {
+    $dateCallback = function ($innerObject, $outerObject, string $attributeName, string $format = null, array $context = []) {
         return $innerObject instanceof \DateTime ? $innerObject->format(\DateTime::ISO8601) : '';
     };
 

deployment/proxies.rst

@@ -93,5 +93,4 @@ In this case, you'll need to set the header ``X-Forwarded-Proto`` with the value
     $response = $kernel->handle($request);
 
 .. _`security groups`: http://docs.aws.amazon.com/elasticloadbalancing/latest/classic/elb-security-groups.html
-.. _`RFC 7239`: http://tools.ietf.org/html/rfc7239
 .. _`CloudFront`: https://en.wikipedia.org/wiki/Amazon_CloudFront

forms.rst

@@ -168,7 +168,7 @@ extend from :class:`Symfony\\Component\\Form\\AbstractType`, which already
 implements the interface and provides some utilities::
 
     // src/Form/Type/TaskType.php
-    namespace App\Form;
+    namespace App\Form\Type;
 
     use Symfony\Component\Form\AbstractType;
     use Symfony\Component\Form\Extension\Core\Type\DateType;
@@ -731,7 +731,7 @@ When building the form, omit the second argument to the ``add()`` method, or
 pass ``null`` to it, to enable Symfony's "guessing mechanism"::
 
     // src/Form/Type/TaskType.php
-    namespace App\Form;
+    namespace App\Form\Type;
 
     use Symfony\Component\Form\AbstractType;
     use Symfony\Component\Form\Extension\Core\Type\DateType;

routing.rst

@@ -1243,8 +1243,8 @@ to get the request and its attributes:
 
 .. code-block:: twig
 
-    {% set route_name = app.request.attributes('_route') %}
-    {% set route_parameters = app.request.attributes('_route_params') %}
+    {% set route_name = app.request.attributes.get('_route') %}
+    {% set route_parameters = app.request.attributes.get('_route_params') %}
 
     {# use this to get all the available attributes (not only routing ones) #}
     {% set all_attributes = app.request.attributes.all %}