Skip to content

Commit 1d56da4

Browse files
committed
feature #4239 Remove redundant references to trusting HttpCache (thewilkybarkid)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4239). Discussion ---------- Remove redundant references to trusting HttpCache | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | Removes references to making `HttpCache` a trusted proxy as symfony/symfony#11937 would cause it to be handled automatically. Alternatively it could be reworded, but I'm not sure it's useful to say that this happens (since it was a bit odd to have to configure Symfony to let one part of the code base trust another). Commits ------- 8f157dc Remove redundant references to trusting HttpCache
2 parents 17addb1 + 7568732 commit 1d56da4

File tree

3 files changed

+0
-16
lines changed

3 files changed

+0
-16
lines changed

book/http_cache.rst

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,10 +163,6 @@ kernel::
163163
The caching kernel will immediately act as a reverse proxy - caching responses
164164
from your application and returning them to the client.
165165

166-
Now that you're using a "proxy", you'll need to configure ``127.0.0.1`` under
167-
the ``trusted_proxies`` configuration (see :ref:`the reference <reference-framework-trusted-proxies>`).
168-
Without this, the client's IP address and a few other things won't report correctly.
169-
170166
.. tip::
171167

172168
The cache kernel has a special ``getLog()`` method that returns a string

components/http_foundation/trusting_proxies.rst

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,6 @@ your proxy.
3030
// only trust proxy headers coming from this IP addresses
3131
Request::setTrustedProxies(array('192.0.0.1', '10.0.0.0/8'));
3232
33-
.. note::
34-
35-
When using Symfony's internal reverse proxy (``AppCache.php``) make sure to add
36-
``127.0.0.1`` to the list of trusted proxies.
37-
38-
3933
Configuring Header Names
4034
------------------------
4135

cookbook/request/load_balancer_reverse_proxy.rst

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,6 @@ special ``X-Forwarded-*`` headers. For example, instead of reading the ``REMOTE_
1111
header (which will now be the IP address of your reverse proxy), the user's
1212
true IP will be stored in an ``X-Forwarded-For`` header.
1313

14-
.. tip::
15-
16-
If you're using Symfony's :ref:`AppCache<symfony-gateway-cache>` for caching,
17-
then you *are* using a reverse proxy with the IP address ``127.0.0.1``.
18-
You'll need to configure that address as a trusted proxy below.
19-
2014
If you don't configure Symfony to look for these headers, you'll get incorrect
2115
information about the client's IP address, whether or not the client is connecting
2216
via HTTPS, the client's port and the hostname being requested.

0 commit comments

Comments
 (0)