Skip to content

Commit 0a9c146

Browse files
committed
minor #4422 Fix typos in code (ifdattic)
This PR was merged into the 2.3 branch. Discussion ---------- Fix typos in code | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | PS 1: As so far I used only yaml files for services not sure if the changes to XML and PHP code blocks are correct PS 2: Maybe I configured something wrong or something like that (or you could point me in the right direction for more information), but I don't think the terminate listener will work. In my opinion when command is exited with exception the exit code should be more than zero, but on `ConsoleTerminateEvent` and even on `ConsoleExceptionEvent` the exit code is `0` Commits ------- 2135b82 Change: ConsoleTerminateListener => ErrorLoggerListener fc403b1 Removed parameters from service d4ba3c0 Fix typos in code
2 parents 4257a27 + 2135b82 commit 0a9c146

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

cookbook/console/logging.rst

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ First configure a listener for console terminate events in the service container
190190
# app/config/services.yml
191191
services:
192192
kernel.listener.command_dispatch:
193-
class: Acme\DemoBundle\EventListener\ConsoleTerminateListener
193+
class: Acme\DemoBundle\EventListener\ErrorLoggerListener
194194
arguments:
195195
logger: "@logger"
196196
tags:
@@ -204,12 +204,8 @@ First configure a listener for console terminate events in the service container
204204
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
205205
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
206206
207-
<parameters>
208-
<parameter key="console_exception_listener.class">Acme\DemoBundle\EventListener\ConsoleExceptionListener</parameter>
209-
</parameters>
210-
211207
<services>
212-
<service id="kernel.listener.command_dispatch" class="%console_exception_listener.class%">
208+
<service id="kernel.listener.command_dispatch" class="Acme\DemoBundle\EventListener\ErrorLoggerListener">
213209
<argument type="service" id="logger"/>
214210
<tag name="kernel.event_listener" event="console.terminate" />
215211
</service>
@@ -222,32 +218,28 @@ First configure a listener for console terminate events in the service container
222218
use Symfony\Component\DependencyInjection\Definition;
223219
use Symfony\Component\DependencyInjection\Reference;
224220
225-
$container->setParameter(
226-
'console_exception_listener.class',
227-
'Acme\DemoBundle\EventListener\ConsoleExceptionListener'
228-
);
229-
$definitionConsoleExceptionListener = new Definition(
230-
'%console_exception_listener.class%',
221+
$definitionErrorLoggerListener = new Definition(
222+
'Acme\DemoBundle\EventListener\ErrorLoggerListener',
231223
array(new Reference('logger'))
232224
);
233-
$definitionConsoleExceptionListener->addTag(
225+
$definitionErrorLoggerListener->addTag(
234226
'kernel.event_listener',
235227
array('event' => 'console.terminate')
236228
);
237229
$container->setDefinition(
238230
'kernel.listener.command_dispatch',
239-
$definitionConsoleExceptionListener
231+
$definitionErrorLoggerListener
240232
);
241233
242234
Then implement the actual listener::
243235

244-
// src/Acme/DemoBundle/EventListener/ConsoleExceptionListener.php
236+
// src/Acme/DemoBundle/EventListener/ErrorLoggerListener.php
245237
namespace Acme\DemoBundle\EventListener;
246238

247239
use Symfony\Component\Console\Event\ConsoleTerminateEvent;
248240
use Psr\Log\LoggerInterface;
249241

250-
class ConsoleExceptionListener
242+
class ErrorLoggerListener
251243
{
252244
private $logger;
253245

0 commit comments

Comments
 (0)