Skip to content

Commit 07ba07c

Browse files
committed
Merge branch '5.4' into 6.0
* 5.4: Emphasise where a method is returning a value. Update security.rst Merging "list" into text Remove Magali from CARE
2 parents 6a9fac0 + a5a7562 commit 07ba07c

File tree

4 files changed

+7
-16
lines changed

4 files changed

+7
-16
lines changed

contributing/code_of_conduct/care_team.rst

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,6 @@ of them at once by emailing ** care@symfony.com **.
3737
* *SymfonyConnect*: `zanbaldwin <https://connect.symfony.com/profile/zanbaldwin>`_
3838
* *SymfonySlack*: `@Zan <https://symfony-devs.slack.com/team/UBHGRU3NW>`_
3939

40-
* **Magali Milbergue**
41-
42-
* *E-mail*: magali.milbergue [at] gmail.com
43-
* *Twitter*: `@magalimilbergue <https://twitter.com/magalimilbergue>`_
44-
* *SymfonyConnect*: `magali_milbergue <https://connect.symfony.com/profile/magali_milbergue>`_
45-
4640
* **Tobias Nyholm**
4741

4842
* *E-mail*: tobias.nyholm [at] gmail.com

controller.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ object. To access it in your controller, add it as an argument and
373373
use Symfony\Component\HttpFoundation\Response;
374374
// ...
375375

376-
public function index(Request $request, string $firstName, string $lastName): Response
376+
public function index(Request $request): Response
377377
{
378378
$page = $request->query->get('page', 1);
379379

security.rst

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ from the `MakerBundle`_:
197197
}
198198
199199
/**
200-
* Returning a salt is only needed, if you are not using a modern
200+
* Returning a salt is only needed if you are not using a modern
201201
* hashing algorithm (e.g. bcrypt or sodium) in your security.yaml.
202202
*
203203
* @see UserInterface
@@ -1857,12 +1857,9 @@ database and every user is *always* given at least one role: ``ROLE_USER``::
18571857
}
18581858

18591859
This is a nice default, but you can do *whatever* you want to determine which roles
1860-
a user should have. Here are a few guidelines:
1861-
1862-
* Every role **must start with** ``ROLE_`` (otherwise, things won't work as expected)
1863-
1864-
* Other than the above rule, a role is just a string and you can invent what you
1865-
need (e.g. ``ROLE_PRODUCT_ADMIN``).
1860+
a user should have. The only rule is that every role **must start with** the
1861+
``ROLE_`` prefix - otherwise, things won't work as expected. Other than that,
1862+
a role is just a string and you can invent whatever you need (e.g. ``ROLE_PRODUCT_ADMIN``).
18661863

18671864
You'll use these roles next to grant access to specific sections of your site.
18681865

testing.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ Retrieving Services in the Test
247247

248248
In your integration tests, you often need to fetch the service from the
249249
service container to call a specific method. After booting the kernel,
250-
the container is stored in ``static::getContainer()``::
250+
the container is returned by ``static::getContainer()``::
251251

252252
// tests/Service/NewsletterGeneratorTest.php
253253
namespace App\Tests\Service;
@@ -273,7 +273,7 @@ the container is stored in ``static::getContainer()``::
273273
}
274274
}
275275

276-
The container in ``static::getContainer()`` is actually a special test container.
276+
The container from ``static::getContainer()`` is actually a special test container.
277277
It gives you access to both the public services and the non-removed
278278
:ref:`private services <container-public>`.
279279

0 commit comments

Comments
 (0)