minor #49621 [Tests] Remove occurrences of withConsecutive() (alexandre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763649 [Tests] Remove occurrences of `withConsecutive()`

Author: nicolas-grekas

Tests/Authentication/DefaultAuthenticationFailureHandlerTest.php

@@ -197,10 +197,15 @@ public function testFailurePathFromRequestWithInvalidUrl()
 
         $this->logger->expects($this->exactly(2))
             ->method('debug')
-            ->withConsecutive(
-                ['Ignoring query parameter "_my_failure_path": not a valid URL.'],
-                ['Authentication failure, redirect triggered.', ['failure_path' => '/login']]
-            );
+            ->willReturnCallback(function (...$args) {
+                static $series = [
+                    ['Ignoring query parameter "_my_failure_path": not a valid URL.', []],
+                    ['Authentication failure, redirect triggered.', ['failure_path' => '/login']],
+                ];
+
+                $expectedArgs = array_shift($series);
+                $this->assertSame($expectedArgs, $args);
+            });
 
         $handler = new DefaultAuthenticationFailureHandler($this->httpKernel, $this->httpUtils, $options, $this->logger);
 

Tests/EventListener/PasswordMigratingListenerTest.php

@@ -85,7 +85,19 @@ public function testUnsupportedPassport()
         // A custom Passport, without an UserBadge
         $passport = $this->createMock(UserPassportInterface::class);
         $passport->method('getUser')->willReturn($this->user);
-        $passport->method('hasBadge')->withConsecutive([PasswordUpgradeBadge::class], [UserBadge::class])->willReturnOnConsecutiveCalls(true, false);
+        $passport->method('hasBadge')
+            ->willReturnCallback(function (...$args) {
+                static $series = [
+                    [[PasswordUpgradeBadge::class], true],
+                    [[UserBadge::class], false],
+                ];
+
+                [$expectedArgs, $return] = array_shift($series);
+                $this->assertSame($expectedArgs, $args);
+
+                return $return;
+            })
+        ;
         $passport->expects($this->once())->method('getBadge')->with(PasswordUpgradeBadge::class)->willReturn(new PasswordUpgradeBadge('pa$$word'));
         // We should never "getBadge" for "UserBadge::class"
 

Tests/LoginLink/LoginLinkHandlerTest.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Security\Http\Tests\LoginLink;
 
+use PHPUnit\Framework\Constraint\Constraint;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Psr\Cache\CacheItemPoolInterface;
@@ -80,9 +81,22 @@ public function testCreateLoginLink($user, array $extraProperties, Request $requ
                 ->method('getContext')
                 ->willReturn($currentRequestContext = new RequestContext());
 
+            $series = [
+                $this->equalTo((new RequestContext())->fromRequest($request)->setParameter('_locale', $request->getLocale())),
+                $currentRequestContext,
+            ];
+
             $this->router->expects($this->exactly(2))
                 ->method('setContext')
-                ->withConsecutive([$this->equalTo((new RequestContext())->fromRequest($request)->setParameter('_locale', $request->getLocale()))], [$currentRequestContext]);
+                ->willReturnCallback(function (RequestContext $context) use (&$series) {
+                    $expectedContext = array_shift($series);
+
+                    if ($expectedContext instanceof Constraint) {
+                        $expectedContext->evaluate($context);
+                    } else {
+                        $this->assertSame($expectedContext, $context);
+                    }
+                });
         }
 
         $loginLink = $this->createLinker([], array_keys($extraProperties))->createLoginLink($user, $request);