Skip to content

Commit 1611801

Browse files
committed
[Security] removed an unused parameter in some private methods
1 parent 1caca1c commit 1611801

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Firewall/AbstractAuthenticationListener.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,14 +149,14 @@ final public function handle(GetResponseEvent $event)
149149
if ($returnValue instanceof TokenInterface) {
150150
$this->sessionStrategy->onAuthentication($request, $returnValue);
151151

152-
$response = $this->onSuccess($event, $request, $returnValue);
152+
$response = $this->onSuccess($request, $returnValue);
153153
} elseif ($returnValue instanceof Response) {
154154
$response = $returnValue;
155155
} else {
156156
throw new \RuntimeException('attemptAuthentication() must either return a Response, an implementation of TokenInterface, or null.');
157157
}
158158
} catch (AuthenticationException $e) {
159-
$response = $this->onFailure($event, $request, $e);
159+
$response = $this->onFailure($request, $e);
160160
}
161161

162162
$event->setResponse($response);
@@ -189,7 +189,7 @@ protected function requiresAuthentication(Request $request)
189189
*/
190190
abstract protected function attemptAuthentication(Request $request);
191191

192-
private function onFailure(GetResponseEvent $event, Request $request, AuthenticationException $failed)
192+
private function onFailure(Request $request, AuthenticationException $failed)
193193
{
194194
if (null !== $this->logger) {
195195
$this->logger->info(sprintf('Authentication request failed: %s', $failed->getMessage()));
@@ -209,7 +209,7 @@ private function onFailure(GetResponseEvent $event, Request $request, Authentica
209209
return $response;
210210
}
211211

212-
private function onSuccess(GetResponseEvent $event, Request $request, TokenInterface $token)
212+
private function onSuccess(Request $request, TokenInterface $token)
213213
{
214214
if (null !== $this->logger) {
215215
$this->logger->info(sprintf('User "%s" has been authenticated successfully', $token->getUsername()));

0 commit comments

Comments
 (0)