[symfony/panther] leverage the new add-lines configurator (#1215)

nicolas-grekas · web-flow · commit dfe6f330760a · 2023-06-19T14:36:41.000+02:00
diff --git a/phpunit/phpunit/4.7/phpunit.xml.dist b/phpunit/phpunit/4.7/phpunit.xml.dist
@@ -30,10 +30,6 @@
         <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
     </listeners>
 
-    <!-- Run `composer require symfony/panther` before enabling this extension -->
-    <!--
     <extensions>
-        <extension class="Symfony\Component\Panther\ServerExtension" />
     </extensions>
-    -->
 </phpunit>
diff --git a/phpunit/phpunit/9.3/phpunit.xml.dist b/phpunit/phpunit/9.3/phpunit.xml.dist
@@ -33,10 +33,6 @@
         <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
     </listeners>
 
-    <!-- Run `composer require symfony/panther` before enabling this extension -->
-    <!--
     <extensions>
-        <extension class="Symfony\Component\Panther\ServerExtension" />
     </extensions>
-    -->
 </phpunit>
diff --git a/symfony/panther/1.0/manifest.json b/symfony/panther/1.0/manifest.json
@@ -12,5 +12,13 @@
         "#RUN wget -q https://github.com/mozilla/geckodriver/releases/download/v$GECKODRIVER_VERSION/geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz; \\",
         "#\ttar -zxf geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz -C /usr/bin; \\",
         "#\trm geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz"
+    ],
+    "add-lines": [
+        {
+            "file": "phpunit.xml.dist",
+            "content": "        <extension class=\"Symfony\\Component\\Panther\\ServerExtension\" />",
+            "position": "after_target",
+            "target": "<extensions>"
+        }
     ]
 }
diff --git a/symfony/panther/1.0/post-install.txt b/symfony/panther/1.0/post-install.txt
@@ -7,6 +7,3 @@
     <fg=green>vendor/bin/bdi detect drivers</>
 
     This step is not necessary when using Docker.
-
-  * To use Panther with PHPUnit,
-    uncomment the snippet registering the Panther extension in <fg=green>phpunit.xml.dist</>
diff --git a/symfony/phpunit-bridge/5.1/phpunit.xml.dist b/symfony/phpunit-bridge/5.1/phpunit.xml.dist
@@ -31,10 +31,6 @@
         <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
     </listeners>
 
-    <!-- Run `composer require symfony/panther` before enabling this extension -->
-    <!--
     <extensions>
-        <extension class="Symfony\Component\Panther\ServerExtension" />
     </extensions>
-    -->
 </phpunit>
diff --git a/symfony/phpunit-bridge/5.3/phpunit.xml.dist b/symfony/phpunit-bridge/5.3/phpunit.xml.dist
@@ -33,10 +33,6 @@
         <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
     </listeners>
 
-    <!-- Run `composer require symfony/panther` before enabling this extension -->
-    <!--
     <extensions>
-        <extension class="Symfony\Component\Panther\ServerExtension" />
     </extensions>
-    -->
 </phpunit>

Original file line number	Diff line number	Diff line change
`@@ -12,5 +12,13 @@`
`12`	`12`	`"#RUN wget -q https://github.com/mozilla/geckodriver/releases/download/v$GECKODRIVER_VERSION/geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz; \\",`
`13`	`13`	`"#\ttar -zxf geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz -C /usr/bin; \\",`
`14`	`14`	`"#\trm geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz"`
	`15`	`+ ],`
	`16`	`+ "add-lines": [`
	`17`	`+ {`
	`18`	`+ "file": "phpunit.xml.dist",`
	`19`	`+ "content": " <extension class=\"Symfony\\Component\\Panther\\ServerExtension\" />",`
	`20`	`+ "position": "after_target",`
	`21`	`+ "target": "<extensions>"`
	`22`	`+ }`
`15`	`23`	`]`
`16`	`24`	`}`