Skip to content

Commit 3e3c184

Browse files
committed
Merge branch '2.7'
* 2.7: (23 commits) [FrameworkBundle] Removed the use of TableHelper Spanish translation for the ```checkDNS``` option introduced in #12956. use Table instead of the deprecated TableHelper [2.3] fix failing test Fixes more deprecation notices as per @stof review. Fixed some deprecations according to @stof feedbacks. Normalizes deprecation notice messages. [Validator] fixes UuidValidator deprecated class namespace. [Form] adds more deprecation notices. [Validator] adds more deprecation notices. [Form] Adds a way to trigger deprecation notice on demand for VirtualFormAwareIterator class. Fixes more deprecation notices. Normalized @deprecated annotations. Removed deprecation notices from test files. Fixes deprecation notices. Reverted trigger_error() function calls on deprecated interfaces to prevent breaking third party projects implementing them. Adds deprecation notices for structures to be removed in 3.0. fixed typo Escape annotations in comments, refs #13089. [2.3] missing cleanup for legacy test ... Conflicts: .travis.yml src/Symfony/Bridge/Monolog/Logger.php src/Symfony/Bridge/Swiftmailer/DataCollector/MessageDataCollector.php src/Symfony/Bridge/Twig/Node/FormEnctypeNode.php src/Symfony/Bundle/FrameworkBundle/Command/RouterApacheDumperCommand.php src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php src/Symfony/Bundle/FrameworkBundle/Controller/Controller.php src/Symfony/Bundle/FrameworkBundle/HttpCache/HttpCache.php src/Symfony/Bundle/FrameworkBundle/Templating/Helper/FormHelper.php src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_1_public.txt src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_1_services.txt src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_1_tag1.txt src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/parameters_1.txt src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/route_collection_1.txt src/Symfony/Bundle/FrameworkBundle/composer.json src/Symfony/Component/Config/Definition/ReferenceDumper.php src/Symfony/Component/Console/Helper/DialogHelper.php src/Symfony/Component/Console/Helper/ProgressHelper.php src/Symfony/Component/Console/Helper/TableHelper.php src/Symfony/Component/Form/Deprecated/FormEvents.php src/Symfony/Component/Form/Extension/HttpFoundation/EventListener/BindRequestListener.php src/Symfony/Component/Form/FormEvents.php src/Symfony/Component/HttpKernel/Debug/ErrorHandler.php src/Symfony/Component/HttpKernel/Debug/ExceptionHandler.php src/Symfony/Component/HttpKernel/Kernel.php src/Symfony/Component/HttpKernel/KernelInterface.php src/Symfony/Component/OptionsResolver/Tests/LegacyOptionsTest.php src/Symfony/Component/Process/Process.php src/Symfony/Component/Routing/Matcher/ApacheUrlMatcher.php src/Symfony/Component/Routing/Matcher/Dumper/ApacheMatcherDumper.php src/Symfony/Component/Yaml/Yaml.php
2 parents 5b0fc46 + 419416d commit 3e3c184

File tree

2 files changed

+25
-10
lines changed

2 files changed

+25
-10
lines changed

OptionsResolver.php

Lines changed: 24 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,20 +1011,24 @@ public function count()
10111011
/**
10121012
* Alias of {@link setDefault()}.
10131013
*
1014-
* @deprecated Deprecated as of Symfony 2.6, to be removed in Symfony 3.0.
1014+
* @deprecated since version 2.6, to be removed in 3.0.
10151015
*/
10161016
public function set($option, $value)
10171017
{
1018+
trigger_error('The '.__METHOD__.' method is deprecated since version 2.6 and will be removed in 3.0. Use the setDefaults() method instead.', E_USER_DEPRECATED);
1019+
10181020
return $this->setDefault($option, $value);
10191021
}
10201022

10211023
/**
10221024
* Shortcut for {@link clear()} and {@link setDefaults()}.
10231025
*
1024-
* @deprecated Deprecated as of Symfony 2.6, to be removed in Symfony 3.0.
1026+
* @deprecated since version 2.6, to be removed in 3.0.
10251027
*/
10261028
public function replace(array $defaults)
10271029
{
1030+
trigger_error('The '.__METHOD__.' method is deprecated since version 2.6 and will be removed in 3.0. Use the clear() and setDefaults() methods instead.', E_USER_DEPRECATED);
1031+
10281032
$this->clear();
10291033

10301034
return $this->setDefaults($defaults);
@@ -1033,40 +1037,48 @@ public function replace(array $defaults)
10331037
/**
10341038
* Alias of {@link setDefault()}.
10351039
*
1036-
* @deprecated Deprecated as of Symfony 2.6, to be removed in Symfony 3.0.
1040+
* @deprecated since version 2.6, to be removed in 3.0.
10371041
*/
10381042
public function overload($option, $value)
10391043
{
1044+
trigger_error('The '.__METHOD__.' method is deprecated since version 2.6 and will be removed in 3.0. Use the setDefault() method instead.', E_USER_DEPRECATED);
1045+
10401046
return $this->setDefault($option, $value);
10411047
}
10421048

10431049
/**
10441050
* Alias of {@link offsetGet()}.
10451051
*
1046-
* @deprecated Deprecated as of Symfony 2.6, to be removed in Symfony 3.0.
1052+
* @deprecated since version 2.6, to be removed in 3.0.
10471053
*/
10481054
public function get($option)
10491055
{
1056+
trigger_error('The '.__METHOD__.' method is deprecated since version 2.6 and will be removed in 3.0. Use the ArrayAccess syntax instead to get an option value.', E_USER_DEPRECATED);
1057+
10501058
return $this->offsetGet($option);
10511059
}
10521060

10531061
/**
10541062
* Alias of {@link offsetExists()}.
10551063
*
1056-
* @deprecated Deprecated as of Symfony 2.6, to be removed in Symfony 3.0.
1064+
* @deprecated since version 2.6, to be removed in 3.0.
10571065
*/
10581066
public function has($option)
10591067
{
1068+
trigger_error('The '.__METHOD__.' method is deprecated since version 2.6 and will be removed in 3.0. Use the ArrayAccess syntax instead to get an option value.', E_USER_DEPRECATED);
1069+
10601070
return $this->offsetExists($option);
10611071
}
10621072

10631073
/**
10641074
* Shortcut for {@link clear()} and {@link setDefaults()}.
10651075
*
1066-
* @deprecated Deprecated as of Symfony 2.6, to be removed in Symfony 3.0.
1076+
* @deprecated since version 2.6, to be removed in 3.0.
10671077
*/
10681078
public function replaceDefaults(array $defaultValues)
10691079
{
1080+
trigger_error('The '.__METHOD__.' method is deprecated since version 2.6 and will be removed in 3.0. Use the clear() and setDefaults() methods instead.', E_USER_DEPRECATED);
1081+
10701082
$this->clear();
10711083

10721084
return $this->setDefaults($defaultValues);
@@ -1075,20 +1087,24 @@ public function replaceDefaults(array $defaultValues)
10751087
/**
10761088
* Alias of {@link setDefined()}.
10771089
*
1078-
* @deprecated Deprecated as of Symfony 2.6, to be removed in Symfony 3.0.
1090+
* @deprecated since version 2.6, to be removed in 3.0.
10791091
*/
10801092
public function setOptional(array $optionNames)
10811093
{
1094+
trigger_error('The '.__METHOD__.' method is deprecated since version 2.6 and will be removed in 3.0. Use the setDefined() method instead.', E_USER_DEPRECATED);
1095+
10821096
return $this->setDefined($optionNames);
10831097
}
10841098

10851099
/**
10861100
* Alias of {@link isDefined()}.
10871101
*
1088-
* @deprecated Deprecated as of Symfony 2.6, to be removed in Symfony 3.0.
1102+
* @deprecated since version 2.6, to be removed in 3.0.
10891103
*/
10901104
public function isKnown($option)
10911105
{
1106+
trigger_error('The '.__METHOD__.' method is deprecated since version 2.6 and will be removed in 3.0. Use the isDefined() method instead.', E_USER_DEPRECATED);
1107+
10921108
return $this->isDefined($option);
10931109
}
10941110

OptionsResolverInterface.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111

1212
namespace Symfony\Component\OptionsResolver;
1313

14-
trigger_error('The "Symfony\Component\OptionsResolver\OptionsResolverInterface" interface was deprecated in version 2.6 and will be removed in 3.0. Use "Symfony\Component\OptionsResolver\OptionsResolver" instead.', E_USER_DEPRECATED);
15-
1614
use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
1715
use Symfony\Component\OptionsResolver\Exception\MissingOptionsException;
1816
use Symfony\Component\OptionsResolver\Exception\OptionDefinitionException;
@@ -22,6 +20,7 @@
2220
*
2321
* @deprecated since version 2.6, to be removed in Symfony 3.0.
2422
* Use {@link OptionsResolver} instead.
23+
* @deprecated since version 2.6, to be removed in 3.0. Use {@link OptionsResolver} instead.
2524
*/
2625
interface OptionsResolverInterface
2726
{

0 commit comments

Comments
 (0)