Skip to content

Commit ea972b4

Browse files
jrushlowbdaler
jrushlow
and
bdaler
authored
[make:crud] use save instead of add repository methods (#1204)
Co-authored-by: bdaler <dalerkbtut@gmail.com>
1 parent 4c20d32 commit ea972b4

File tree

7 files changed

+16
-16
lines changed

7 files changed

+16
-16
lines changed

‎src/Resources/skeleton/crud/controller/Controller.tpl.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function index(EntityManagerInterface $entityManager): Response
2929
<?php endif ?>
3030

3131
<?= $generator->generateRouteForControllerMethod('/new', sprintf('%s_new', $route_name), ['GET', 'POST']) ?>
32-
<?php if (isset($repository_full_class_name) && $generator->repositoryHasAddRemoveMethods($repository_full_class_name)) { ?>
32+
<?php if (isset($repository_full_class_name) && $generator->repositoryHasSaveAndRemoveMethods($repository_full_class_name)) { ?>
3333
public function new(Request $request, <?= $repository_class_name ?> $<?= $repository_var ?>): Response
3434
<?php } else { ?>
3535
public function new(Request $request, EntityManagerInterface $entityManager): Response
@@ -39,9 +39,9 @@ public function new(Request $request, EntityManagerInterface $entityManager): Re
3939
$form = $this->createForm(<?= $form_class_name ?>::class, $<?= $entity_var_singular ?>);
4040
$form->handleRequest($request);
4141

42-
<?php if (isset($repository_full_class_name) && $generator->repositoryHasAddRemoveMethods($repository_full_class_name)) { ?>
42+
<?php if (isset($repository_full_class_name) && $generator->repositoryHasSaveAndRemoveMethods($repository_full_class_name)) { ?>
4343
if ($form->isSubmitted() && $form->isValid()) {
44-
$<?= $repository_var ?>->add($<?= $entity_var_singular ?>, true);
44+
$<?= $repository_var ?>->save($<?= $entity_var_singular ?>, true);
4545

4646
return $this->redirectToRoute('<?= $route_name ?>_index', [], Response::HTTP_SEE_OTHER);
4747
}
@@ -76,7 +76,7 @@ public function show(<?= $entity_class_name ?> $<?= $entity_var_singular ?>): Re
7676
}
7777

7878
<?= $generator->generateRouteForControllerMethod(sprintf('/{%s}/edit', $entity_identifier), sprintf('%s_edit', $route_name), ['GET', 'POST']) ?>
79-
<?php if (isset($repository_full_class_name) && $generator->repositoryHasAddRemoveMethods($repository_full_class_name)) { ?>
79+
<?php if (isset($repository_full_class_name) && $generator->repositoryHasSaveAndRemoveMethods($repository_full_class_name)) { ?>
8080
public function edit(Request $request, <?= $entity_class_name ?> $<?= $entity_var_singular ?>, <?= $repository_class_name ?> $<?= $repository_var ?>): Response
8181
<?php } else { ?>
8282
public function edit(Request $request, <?= $entity_class_name ?> $<?= $entity_var_singular ?>, EntityManagerInterface $entityManager): Response
@@ -85,9 +85,9 @@ public function edit(Request $request, <?= $entity_class_name ?> $<?= $entity_va
8585
$form = $this->createForm(<?= $form_class_name ?>::class, $<?= $entity_var_singular ?>);
8686
$form->handleRequest($request);
8787

88-
<?php if (isset($repository_full_class_name) && $generator->repositoryHasAddRemoveMethods($repository_full_class_name)) { ?>
88+
<?php if (isset($repository_full_class_name) && $generator->repositoryHasSaveAndRemoveMethods($repository_full_class_name)) { ?>
8989
if ($form->isSubmitted() && $form->isValid()) {
90-
$<?= $repository_var ?>->add($<?= $entity_var_singular ?>, true);
90+
$<?= $repository_var ?>->save($<?= $entity_var_singular ?>, true);
9191

9292
return $this->redirectToRoute('<?= $route_name ?>_index', [], Response::HTTP_SEE_OTHER);
9393
}
@@ -113,13 +113,13 @@ public function edit(Request $request, <?= $entity_class_name ?> $<?= $entity_va
113113
}
114114

115115
<?= $generator->generateRouteForControllerMethod(sprintf('/{%s}', $entity_identifier), sprintf('%s_delete', $route_name), ['POST']) ?>
116-
<?php if (isset($repository_full_class_name) && $generator->repositoryHasAddRemoveMethods($repository_full_class_name)) { ?>
116+
<?php if (isset($repository_full_class_name) && $generator->repositoryHasSaveAndRemoveMethods($repository_full_class_name)) { ?>
117117
public function delete(Request $request, <?= $entity_class_name ?> $<?= $entity_var_singular ?>, <?= $repository_class_name ?> $<?= $repository_var ?>): Response
118118
<?php } else { ?>
119119
public function delete(Request $request, <?= $entity_class_name ?> $<?= $entity_var_singular ?>, EntityManagerInterface $entityManager): Response
120120
<?php } ?>
121121
{
122-
<?php if (isset($repository_full_class_name) && $generator->repositoryHasAddRemoveMethods($repository_full_class_name)) { ?>
122+
<?php if (isset($repository_full_class_name) && $generator->repositoryHasSaveAndRemoveMethods($repository_full_class_name)) { ?>
123123
if ($this->isCsrfTokenValid('delete'.$<?= $entity_var_singular ?>->get<?= ucfirst($entity_identifier) ?>(), $request->request->get('_token'))) {
124124
$<?= $repository_var ?>->remove($<?= $entity_var_singular ?>, true);
125125
}

‎src/Resources/skeleton/doctrine/Repository.tpl.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public function __construct(ManagerRegistry $registry)
1919
parent::__construct($registry, <?= $entity_class_name; ?>::class);
2020
}
2121

22-
public function add(<?= $entity_class_name ?> $entity, bool $flush = false): void
22+
public function save(<?= $entity_class_name ?> $entity, bool $flush = false): void
2323
{
2424
$this->getEntityManager()->persist($entity);
2525

‎src/Util/TemplateComponentGenerator.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ public function getPropertyType(ClassNameDetails $classNameDetails): ?string
5050
/**
5151
* @throws ReflectionException
5252
*/
53-
public function repositoryHasAddRemoveMethods(string $repositoryFullClassName): bool
53+
public function repositoryHasSaveAndRemoveMethods(string $repositoryFullClassName): bool
5454
{
5555
$reflectedComponents = new ReflectionClass($repositoryFullClassName);
5656

57-
return $reflectedComponents->hasMethod('add') && $reflectedComponents->hasMethod('remove');
57+
return $reflectedComponents->hasMethod('save') && $reflectedComponents->hasMethod('remove');
5858
}
5959
}

‎tests/Doctrine/fixtures/expected_xml/src/Repository/UserRepository.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public function __construct(ManagerRegistry $registry)
2121
parent::__construct($registry, UserXml::class);
2222
}
2323

24-
public function add(UserXml $entity, bool $flush = false): void
24+
public function save(UserXml $entity, bool $flush = false): void
2525
{
2626
$this->getEntityManager()->persist($entity);
2727

‎tests/Doctrine/fixtures/expected_xml/src/Repository/XOtherRepository.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public function __construct(ManagerRegistry $registry)
2121
parent::__construct($registry, XOther::class);
2222
}
2323

24-
public function add(XOther $entity, bool $flush = false): void
24+
public function save(XOther $entity, bool $flush = false): void
2525
{
2626
$this->getEntityManager()->persist($entity);
2727

‎tests/fixtures/make-crud/SweetFoodRepository.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public function __construct(ManagerRegistry $registry)
2121
parent::__construct($registry, SweetFood::class);
2222
}
2323

24-
public function add(SweetFood $entity, bool $flush = false): void
24+
public function save(SweetFood $entity, bool $flush = false): void
2525
{
2626
($em = $this->getEntityManager())->persist($entity);
2727

‎tests/fixtures/make-crud/expected/WithCustomRepository.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function new(Request $request, SweetFoodRepository $sweetFoodRepository):
2929
$form->handleRequest($request);
3030

3131
if ($form->isSubmitted() && $form->isValid()) {
32-
$sweetFoodRepository->add($sweetFood, true);
32+
$sweetFoodRepository->save($sweetFood, true);
3333

3434
return $this->redirectToRoute('app_sweet_food_index', [], Response::HTTP_SEE_OTHER);
3535
}
@@ -55,7 +55,7 @@ public function edit(Request $request, SweetFood $sweetFood, SweetFoodRepository
5555
$form->handleRequest($request);
5656

5757
if ($form->isSubmitted() && $form->isValid()) {
58-
$sweetFoodRepository->add($sweetFood, true);
58+
$sweetFoodRepository->save($sweetFood, true);
5959

6060
return $this->redirectToRoute('app_sweet_food_index', [], Response::HTTP_SEE_OTHER);
6161
}

0 commit comments

Comments
 (0)