Skip to content

Commit c557553

Browse files
committed
bug #1084 [make:docker:database] Fix link docker compose file ports (mdoutreluingne)
This PR was squashed before being merged into the 1.0-dev branch. Discussion ---------- [make:docker:database] Fix link docker compose file ports Hi, For this PR I: - Fix link for the Docker compose file ports - Added color yellow for the database service name Commits ------- 2a71481 [make:docker:database] Fix link docker compose file ports
2 parents b2eacf5 + 2a71481 commit c557553

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/Maker/MakeDockerDatabase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ public function interact(InputInterface $input, ConsoleStyle $io, Command $comma
108108

109109
$io->text($serviceNameMsg);
110110

111-
$this->serviceName = $io->ask(sprintf('What name should we call the new %s service? e.g. database', $this->serviceName), null, [Validator::class, 'notBlank']);
111+
$this->serviceName = $io->ask(sprintf('What name should we call the new %s service? (e.g. <fg=yellow>database</>)', $this->serviceName), null, [Validator::class, 'notBlank']);
112112
}
113113

114114
$this->checkForPDOSupport($this->databaseChoice, $io);

src/Util/ComposeFileManipulator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public function exposePorts(string $service, array $ports): void
8787
$portData[] = sprintf('%s To allow the host machine to access the ports below, modify the lines below.', YamlSourceManipulator::COMMENT_PLACEHOLDER_VALUE);
8888
$portData[] = sprintf('%s For example, to allow the host to connect to port 3306 on the container, you would change', YamlSourceManipulator::COMMENT_PLACEHOLDER_VALUE);
8989
$portData[] = sprintf('%s "3306" to "3306:3306". Where the first port is exposed to the host and the second is the container port.', YamlSourceManipulator::COMMENT_PLACEHOLDER_VALUE);
90-
$portData[] = sprintf('%s See https://docs.docker.com/compose/compose-file/#ports for more information.', YamlSourceManipulator::COMMENT_PLACEHOLDER_VALUE);
90+
$portData[] = sprintf('%s See https://docs.docker.com/compose/compose-file/compose-file-v3/#ports for more information.', YamlSourceManipulator::COMMENT_PLACEHOLDER_VALUE);
9191

9292
foreach ($ports as $port) {
9393
$portData[] = $port;

0 commit comments

Comments
 (0)