crud: send the proper HTTP status codes and use renderForm() when available

Author: dunglas

src/Maker/MakeCrud.php

@@ -15,6 +15,7 @@
 use Doctrine\Common\Inflector\Inflector as LegacyInflector;
 use Doctrine\Inflector\InflectorFactory;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Bundle\MakerBundle\ConsoleStyle;
 use Symfony\Bundle\MakerBundle\DependencyBuilder;
 use Symfony\Bundle\MakerBundle\Doctrine\DoctrineHelper;
@@ -168,6 +169,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
                     'entity_var_singular' => $entityVarSingular,
                     'entity_twig_var_singular' => $entityTwigVarSingular,
                     'entity_identifier' => $entityDoctrineDetails->getIdentifier(),
+                    'use_render_form' => method_exists(AbstractController::class, 'renderForm'),
                 ],
                 $repositoryVars
             )

src/Resources/skeleton/crud/controller/Controller.tpl.php

@@ -66,13 +66,20 @@ public function new(Request $request): Response
             $entityManager->persist($<?= $entity_var_singular ?>);
             $entityManager->flush();
 
-            return $this->redirectToRoute('<?= $route_name ?>_index');
+            return $this->redirectToRoute('<?= $route_name ?>_index', [], Response::HTTP_SEE_OTHER);
         }
 
+<?php if ($use_render_form) { ?>
+        return $this->renderForm('<?= $templates_path ?>/new.html.twig', [
+            '<?= $entity_twig_var_singular ?>' => $<?= $entity_var_singular ?>,
+            'form' => $form,
+        ]);
+<?php } else { ?>
         return $this->render('<?= $templates_path ?>/new.html.twig', [
             '<?= $entity_twig_var_singular ?>' => $<?= $entity_var_singular ?>,
             'form' => $form->createView(),
         ]);
+<?php } ?>
     }
 
 <?php if ($use_attributes) { ?>
@@ -104,13 +111,20 @@ public function edit(Request $request, <?= $entity_class_name ?> $<?= $entity_va
         if ($form->isSubmitted() && $form->isValid()) {
             $this->getDoctrine()->getManager()->flush();
 
-            return $this->redirectToRoute('<?= $route_name ?>_index');
+            return $this->redirectToRoute('<?= $route_name ?>_index', [], Response::HTTP_SEE_OTHER);
         }
 
+<?php if ($use_render_form) { ?>
+        return $this->renderForm('<?= $templates_path ?>/edit.html.twig', [
+            '<?= $entity_twig_var_singular ?>' => $<?= $entity_var_singular ?>,
+            'form' => $form,
+        ]);
+<?php } else { ?>
         return $this->render('<?= $templates_path ?>/edit.html.twig', [
             '<?= $entity_twig_var_singular ?>' => $<?= $entity_var_singular ?>,
             'form' => $form->createView(),
         ]);
+<?php } ?>
     }
 
 <?php if ($use_attributes) { ?>
@@ -128,6 +142,6 @@ public function delete(Request $request, <?= $entity_class_name ?> $<?= $entity_
             $entityManager->flush();
         }
 
-        return $this->redirectToRoute('<?= $route_name ?>_index');
+        return $this->redirectToRoute('<?= $route_name ?>_index', [], Response::HTTP_SEE_OTHER);
     }
 }