[Notifier] Use abstract test cases in 5.2

Author: OskarStark

Tests/LinkedInTransportFactoryTest.php

@@ -2,55 +2,41 @@
 
 namespace Symfony\Component\Notifier\Bridge\LinkedIn\Tests;
 
-use PHPUnit\Framework\TestCase;
 use Symfony\Component\Notifier\Bridge\LinkedIn\LinkedInTransportFactory;
-use Symfony\Component\Notifier\Exception\IncompleteDsnException;
-use Symfony\Component\Notifier\Exception\UnsupportedSchemeException;
-use Symfony\Component\Notifier\Transport\Dsn;
+use Symfony\Component\Notifier\Tests\TransportFactoryTestCase;
+use Symfony\Component\Notifier\Transport\TransportFactoryInterface;
 
-final class LinkedInTransportFactoryTest extends TestCase
+final class LinkedInTransportFactoryTest extends TransportFactoryTestCase
 {
-    public function testCreateWithDsn()
+    /**
+     * @return LinkedInTransportFactory
+     */
+    public function createFactory(): TransportFactoryInterface
     {
-        $factory = $this->createFactory();
-
-        $transport = $factory->create(Dsn::fromString('linkedin://accessToken:UserId@host.test'));
-
-        $this->assertSame('linkedin://host.test', (string) $transport);
-    }
-
-    public function testCreateWithOnlyAccessTokenOrUserIdThrowsIncompleteDsnException()
-    {
-        $factory = $this->createFactory();
-
-        $this->expectException(IncompleteDsnException::class);
-        $factory->create(Dsn::fromString('linkedin://AccessTokenOrUserId@default'));
+        return new LinkedInTransportFactory();
     }
 
-    public function testSupportsReturnsTrueWithSupportedScheme()
+    public function createProvider(): iterable
     {
-        $factory = $this->createFactory();
-
-        $this->assertTrue($factory->supports(Dsn::fromString('linkedin://host/path')));
+        yield [
+            'linkedin://host.test',
+            'linkedin://accessToken:UserId@host.test',
+        ];
     }
 
-    public function testSupportsReturnsFalseWithUnsupportedScheme()
+    public function supportsProvider(): iterable
     {
-        $factory = $this->createFactory();
-
-        $this->assertFalse($factory->supports(Dsn::fromString('somethingElse://host/path')));
+        yield [true, 'linkedin://host'];
+        yield [false, 'somethingElse://host'];
     }
 
-    public function testUnsupportedSchemeThrowsUnsupportedSchemeException()
+    public function incompleteDsnProvider(): iterable
     {
-        $factory = $this->createFactory();
-
-        $this->expectException(UnsupportedSchemeException::class);
-        $factory->create(Dsn::fromString('somethingElse://accessToken:UserId@default'));
+        yield 'missing account or user_id' => ['linkedin://AccessTokenOrUserId@default'];
     }
 
-    private function createFactory(): LinkedInTransportFactory
+    public function unsupportedSchemeProvider(): iterable
     {
-        return new LinkedInTransportFactory();
+        yield ['somethingElse://accessToken:UserId@default'];
     }
 }

Tests/LinkedInTransportTest.php

@@ -2,47 +2,48 @@
 
 namespace Symfony\Component\Notifier\Bridge\LinkedIn\Tests;
 
-use PHPUnit\Framework\TestCase;
 use Symfony\Component\HttpClient\MockHttpClient;
 use Symfony\Component\Notifier\Bridge\LinkedIn\LinkedInTransport;
 use Symfony\Component\Notifier\Exception\LogicException;
 use Symfony\Component\Notifier\Exception\TransportException;
 use Symfony\Component\Notifier\Message\ChatMessage;
 use Symfony\Component\Notifier\Message\MessageInterface;
 use Symfony\Component\Notifier\Message\MessageOptionsInterface;
+use Symfony\Component\Notifier\Message\SmsMessage;
 use Symfony\Component\Notifier\Notification\Notification;
+use Symfony\Component\Notifier\Tests\TransportTestCase;
+use Symfony\Component\Notifier\Transport\TransportInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 use Symfony\Contracts\HttpClient\ResponseInterface;
 
-final class LinkedInTransportTest extends TestCase
+final class LinkedInTransportTest extends TransportTestCase
 {
-    public function testToStringContainsProperties()
+    /**
+     * @return LinkedInTransport
+     */
+    public function createTransport(?HttpClientInterface $client = null): TransportInterface
     {
-        $transport = $this->createTransport();
-
-        $this->assertSame('linkedin://host.test', (string) $transport);
+        return (new LinkedInTransport('AuthToken', 'AccountId', $client ?: $this->createMock(HttpClientInterface::class)))->setHost('host.test');
     }
 
-    public function testSupportsChatMessage()
+    public function toStringProvider(): iterable
     {
-        $transport = $this->createTransport();
-
-        $this->assertTrue($transport->supports(new ChatMessage('testChatMessage')));
-        $this->assertFalse($transport->supports($this->createMock(MessageInterface::class)));
+        yield ['linkedin://host.test', $this->createTransport()];
     }
 
-    public function testSendNonChatMessageThrows()
+    public function supportedMessagesProvider(): iterable
     {
-        $transport = $this->createTransport();
-
-        $this->expectException(LogicException::class);
-        $transport->send($this->createMock(MessageInterface::class));
+        yield [new ChatMessage('Hello!')];
     }
 
-    public function testSendWithEmptyArrayResponseThrows()
+    public function unsupportedMessagesProvider(): iterable
     {
-        $this->expectException(TransportException::class);
+        yield [new SmsMessage('0611223344', 'Hello!')];
+        yield [$this->createMock(MessageInterface::class)];
+    }
 
+    public function testSendWithEmptyArrayResponseThrowsTransportException()
+    {
         $response = $this->createMock(ResponseInterface::class);
         $response->expects($this->exactly(2))
             ->method('getStatusCode')
@@ -57,10 +58,12 @@ public function testSendWithEmptyArrayResponseThrows()
 
         $transport = $this->createTransport($client);
 
+        $this->expectException(TransportException::class);
+
         $transport->send(new ChatMessage('testMessage'));
     }
 
-    public function testSendWithErrorResponseThrows()
+    public function testSendWithErrorResponseThrowsTransportException()
     {
         $this->expectException(TransportException::class);
         $this->expectExceptionMessage('testErrorCode');
@@ -187,9 +190,4 @@ public function testSendWithInvalidOptions()
 
         $transport->send(new ChatMessage('testMessage', $this->createMock(MessageOptionsInterface::class)));
     }
-
-    private function createTransport(?HttpClientInterface $client = null): LinkedInTransport
-    {
-        return (new LinkedInTransport('AuthToken', 'AccountId', $client ?? $this->createMock(HttpClientInterface::class)))->setHost('host.test');
-    }
 }

composer.json

@@ -18,7 +18,7 @@
     "require": {
         "php": ">=7.2.5",
         "symfony/http-client": "^4.3|^5.0",
-        "symfony/notifier": "~5.2.0"
+        "symfony/notifier": "~5.2.2"
     },
     "autoload": {
         "psr-4": { "Symfony\\Component\\Notifier\\Bridge\\LinkedIn\\": "" },