Merge branch '5.4' into 6.0

* 5.4:
  [Messenger] cs fix
  [Messenger] Fix time-limit check exception
  [Console] Fix console `ProgressBar::override()` after manual `ProgressBar::cleanup()`
  [FrameworkBundle] typo default_lifetime example
  [HttpClient] Handle Amp HTTP client v5 incompatibility gracefully
  [HttpKernel] Don’t try to wire Response argument with controller.service_arguments
  [PhpUnitBridge] Fix language deprecations incorrectly marked as direct
  Tell about messenger:consume invalid limit options
  [Messenger] Do not throw 'no handlers' exception when skipping due to duplicate handling

Author: nicolas-grekas

DependencyInjection/RegisterControllerArgumentLocatorsPass.php

@@ -24,6 +24,7 @@
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\DependencyInjection\TypedReference;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\Session\SessionInterface;
 
 /**
@@ -157,7 +158,7 @@ public function process(ContainerBuilder $container)
                         $invalidBehavior = ContainerInterface::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE;
                     }
 
-                    if (Request::class === $type || SessionInterface::class === $type) {
+                    if (Request::class === $type || SessionInterface::class === $type || Response::class === $type) {
                         continue;
                     }
 

Tests/DependencyInjection/RegisterControllerArgumentLocatorsPassTest.php

@@ -23,6 +23,7 @@
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\DependencyInjection\ServiceLocator;
 use Symfony\Component\DependencyInjection\TypedReference;
+use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\DependencyInjection\RegisterControllerArgumentLocatorsPass;
 use Symfony\Component\HttpKernel\Tests\Fixtures\Suit;
 
@@ -444,6 +445,20 @@ public function testBindWithTarget()
         ];
         $this->assertEquals($expected, $locator->getArgument(0));
     }
+
+    public function testResponseArgumentIsIgnored()
+    {
+        $container = new ContainerBuilder();
+        $resolver = $container->register('argument_resolver.service', 'stdClass')->addArgument([]);
+
+        $container->register('foo', WithResponseArgument::class)
+            ->addTag('controller.service_arguments');
+
+        (new RegisterControllerArgumentLocatorsPass())->process($container);
+
+        $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
+        $this->assertEmpty(array_keys($locator), 'Response typed argument is ignored');
+    }
 }
 
 class RegisterTestController
@@ -524,3 +539,10 @@ public function fooAction(
     ) {
     }
 }
+
+class WithResponseArgument
+{
+    public function fooAction(Response $response, ?Response $nullableResponse)
+    {
+    }
+}